Skip to content

fix pasting of markdown containing links #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keithamus merged 7 commits into from
Mar 21, 2024
Merged

fix pasting of markdown containing links #93

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fd65fcc
fix pasting of markdown containing links
susanwere Feb 23, 2024
025f305
remove tests
susanwere Feb 23, 2024
a4ae795
fix pasting of markdown that contain links
Mar 19, 2024
7bbe4ac
update changes to fix pasting of markdown
Mar 20, 2024
d064c12
restore package-lock.json
Mar 20, 2024
893f178
Merge branch 'main' into fix-pasting-markdown-with-html
Mar 20, 2024
8d487f9
fix lint error
Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into fix-pasting-markdown-with-html
  • Loading branch information
Susan Were Susan Were
Susan Were authored and Susan Were committed Mar 20, 2024
commit 893f17848df1b75dd8db34af95d128e2cb0c8519
14 changes: 4 additions & 10 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

84 changes: 42 additions & 42 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,31 @@ describe('paste-markdown', function () {
assert.equal(textarea.value, markdownSentence)
})

it('finds the right link when identical labels are present', function () {
// eslint-disable-next-line github/unescaped-html-literal
const sentence = `<meta charset='utf-8'><span>example<span> </span>
</span><a href="https://example.com/">example</a>`
const plaintextSentence = 'example example'
const markdownSentence = 'example [example](https://example.com/)'

paste(textarea, {'text/html': sentence, 'text/plain': plaintextSentence})
assert.equal(textarea.value, markdownSentence)
})

it('skip markdown formatting with (Ctrl+Shift+v)', function () {
const data = {
'text/html': tableHtml,
}

dispatchSkipFormattingKeyEvent(textarea)
paste(textarea, data)
assertUnformattedPaste(textarea)

textarea.value = ''
paste(textarea, data)
assert.include(textarea.value, tableMarkdown)
})

it('pastes markdown with links correctly when identical labels are present', function () {
Comment thread
susanwere marked this conversation as resolved.
// eslint-disable-next-line github/unescaped-html-literal
const sentence = `<meta charset='utf-8'><span>
Expand Down Expand Up @@ -396,12 +421,24 @@ describe('paste-markdown', function () {
assert.equal(textarea.value, markdownSentence)
})

it('finds the right link when identical labels are present', function () {
it('pastes markdown with link labels that contains special characters in html', function () {
// eslint-disable-next-line github/unescaped-html-literal
const sentence = `<meta charset='utf-8'><span>example<span> </span>
</span><a href="https://example.com/">example</a>`
const plaintextSentence = 'example example'
const markdownSentence = 'example [example](https://example.com/)'
const sentence = `<meta charset='utf-8'>
<p>foo&bar <a href="https://www.abcxyz.org/">foo bar</a> <a href="https://example.com/?q=foo&bar=baz">foo&bar</a></p>`
const plaintextSentence = 'foo&bar foo bar foo&bar'
const markdownSentence =
'foo&bar [foo bar](https://www.abcxyz.org/) [foo&bar](https://example.com/?q=foo&bar=baz)'

paste(textarea, {'text/html': sentence, 'text/plain': plaintextSentence})
assert.equal(textarea.value, markdownSentence)
})

it('pastes markdown with link labels that contains emojis in html', function () {
// eslint-disable-next-line github/unescaped-html-literal
const sentence = `<meta charset='utf-8'>
<p>foo bar <a href="https://www.abcxyz.org/">foo</a> bar foo <a href="https://example.com/">🚀 bar 🚀</a></p>`
const plaintextSentence = 'foo bar foo bar foo 🚀 bar 🚀'
const markdownSentence = 'foo bar [foo](https://www.abcxyz.org/) bar foo [🚀 bar 🚀](https://example.com/)'

paste(textarea, {'text/html': sentence, 'text/plain': plaintextSentence})
assert.equal(textarea.value, markdownSentence)
Expand Down Expand Up @@ -445,43 +482,6 @@ bar bar foo`
paste(textarea, {'text/html': sentence, 'text/plain': plaintextSentence})
assert.equal(textarea.value, markdownSentence)
})

it('skip markdown formatting with (Ctrl+Shift+v)', function () {
const data = {
'text/html': tableHtml
}

dispatchSkipFormattingKeyEvent(textarea)
paste(textarea, data)
assertUnformattedPaste(textarea)

textarea.value = ''
paste(textarea, data)
assert.include(textarea.value, tableMarkdown)
})

it('pastes markdown with link labels that contains special characters in html', function () {
// eslint-disable-next-line github/unescaped-html-literal
const sentence = `<meta charset='utf-8'>
<p>foo&bar <a href="https://www.abcxyz.org/">foo bar</a> <a href="https://example.com/?q=foo&bar=baz">foo&bar</a></p>`
const plaintextSentence = 'foo&bar foo bar foo&bar'
const markdownSentence =
'foo&bar [foo bar](https://www.abcxyz.org/) [foo&bar](https://example.com/?q=foo&bar=baz)'

paste(textarea, {'text/html': sentence, 'text/plain': plaintextSentence})
assert.equal(textarea.value, markdownSentence)
})

it('pastes markdown with link labels that contains emojis in html', function () {
// eslint-disable-next-line github/unescaped-html-literal
const sentence = `<meta charset='utf-8'>
<p>foo bar <a href="https://www.abcxyz.org/">foo</a> bar foo <a href="https://example.com/">🚀 bar 🚀</a></p>`
const plaintextSentence = 'foo bar foo bar foo 🚀 bar 🚀'
const markdownSentence = 'foo bar [foo](https://www.abcxyz.org/) bar foo [🚀 bar 🚀](https://example.com/)'

paste(textarea, {'text/html': sentence, 'text/plain': plaintextSentence})
assert.equal(textarea.value, markdownSentence)
})
})
})

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.