Conversation
Mirror the less-equal source component in every master so the greater-equal ligature points right. Add a source regression test for all six masters.
|
Hi! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #131 by mirroring the
less_equal.ligacomponent used bygreater_equal.ligain all six Mona Sans Mono masters. The>=ligature now points right while preserving the existing source outline and metrics.Verification
PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s tests -v— passed. The regression check covers all six masters and fails against the original source, which has zero mirrored components.hb-shapeselectsgreater_equal.ligafor>=, andhb-viewshows the original TTF pointing left and the new TTF pointing right.This PR changes the Glyphs source. Distribution font files will need regeneration during the normal release build.