Conversation
ArshVermaGit
left a comment
ArshVermaGit
left a comment
There was a problem hiding this comment.
Makes sense — putting !Build/ after Build lets git properly un-ignore the directory so Module::Build works as expected. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to the application or project's homepage
https://metacpan.org/pod/Module::Build
Reasons for making this change
!Build/was added right afterBuildso that a directory namedBuildis not ignored, only theBuildscript thatperl Build.PLgenerates. When the template was reorganized into sections,!Build/ended up on the first line, beforeBuild, and since the last matching pattern wins it no longer has any effect. This moves it back underBuildin the Module::Build section; withgit check-ignore -v,Build/x.pmis no longer ignored while theBuildfile still is.Links to documentation supporting these rule changes
Merge and Approval Steps