remove incorrect diff param

mattdholloway · Sep 1, 2025 · Aug 27, 2025 · Aug 27, 2025 · Aug 27, 2025 · Aug 27, 2025
commit 278b94e109cdd1a0708e2a9af2730c6fc463f816
diff --git a/pkg/github/__toolsnaps__/list_commits.snap b/pkg/github/__toolsnaps__/list_commits.snap
@@ -10,10 +10,6 @@
         "description": "Author username or email address to filter commits by",
         "type": "string"
       },
-      "include_diffs": {
-        "description": "Whether to include file diffs and stats in the response. Default is false for faster responses.",
-        "type": "boolean"
-      },
       "owner": {
         "description": "Repository owner",
         "type": "string"

@@ -213,9 +213,6 @@ func ListCommits(getClient GetClientFn, t translations.TranslationHelperFunc) (t
 			mcp.WithString("author",
 				mcp.Description("Author username or email address to filter commits by"),
 			),
-			mcp.WithBoolean("include_diffs",
-				mcp.Description("Whether to include file diffs and stats in the response. Default is false for faster responses."),
-			),
 			WithPagination(),
 		),
 		func(ctx context.Context, request mcp.CallToolRequest) (*mcp.CallToolResult, error) {
@@ -235,10 +232,6 @@ func ListCommits(getClient GetClientFn, t translations.TranslationHelperFunc) (t
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
 			}
-			includeDiffs, err := OptionalParam[bool](request, "include_diffs")
-			if err != nil {
-				return mcp.NewToolResultError(err.Error()), nil
-			}
 			pagination, err := OptionalPaginationParams(request)
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
@@ -282,7 +275,7 @@ func ListCommits(getClient GetClientFn, t translations.TranslationHelperFunc) (t
 			// Convert to minimal commits
 			minimalCommits := make([]MinimalCommit, 0, len(commits))
 			for _, commit := range commits {
-				minimalCommits = append(minimalCommits, convertToMinimalCommit(commit, includeDiffs))
+				minimalCommits = append(minimalCommits, convertToMinimalCommit(commit, false))
 			}
 
 			r, err := json.Marshal(minimalCommits)

@@ -720,7 +720,6 @@ func Test_ListCommits(t *testing.T) {
 	assert.Contains(t, tool.InputSchema.Properties, "repo")
 	assert.Contains(t, tool.InputSchema.Properties, "sha")
 	assert.Contains(t, tool.InputSchema.Properties, "author")
-	assert.Contains(t, tool.InputSchema.Properties, "include_diffs")
 	assert.Contains(t, tool.InputSchema.Properties, "page")
 	assert.Contains(t, tool.InputSchema.Properties, "perPage")
 	assert.ElementsMatch(t, tool.InputSchema.Required, []string{"owner", "repo"})
@@ -931,25 +930,9 @@ func Test_ListCommits(t *testing.T) {
 					assert.Equal(t, tc.expectedCommits[i].Author.GetLogin(), commit.Author.Login)
 				}
 
-				// Check if diffs are included based on include_diffs parameter
-				includeDiffs, exists := tc.requestArgs["include_diffs"]
-				if exists && includeDiffs == true {
-					// When include_diffs=true, files and stats should be present
-					if len(tc.expectedCommits[i].Files) > 0 {
-						assert.NotNil(t, commit.Files)
-						assert.Len(t, commit.Files, len(tc.expectedCommits[i].Files))
-					}
-					if tc.expectedCommits[i].Stats != nil {
-						assert.NotNil(t, commit.Stats)
-						assert.Equal(t, tc.expectedCommits[i].Stats.GetAdditions(), commit.Stats.Additions)
-						assert.Equal(t, tc.expectedCommits[i].Stats.GetDeletions(), commit.Stats.Deletions)
-						assert.Equal(t, tc.expectedCommits[i].Stats.GetTotal(), commit.Stats.Total)
-					}
-				} else {
-					// When include_diffs=false or not specified (default is false for performance), files and stats should not be present
-					assert.Nil(t, commit.Files)
-					assert.Nil(t, commit.Stats)
-				}
+				// Files and stats are never included in list_commits (only available in individual commit queries)
+				assert.Nil(t, commit.Files)
+				assert.Nil(t, commit.Stats)
 			}
 		})
 	}