Skip to content

Add support for rulesets and custom properties. #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
patrick-knight wants to merge 9 commits into from
Closed

Add support for rulesets and custom properties. #821

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
72a5ce7
Add support for rulesets and custom properties.
patrick-knight Aug 5, 2025
77b8a64
Delete pkg/github/discussions_test.go
patrick-knight Aug 5, 2025
26f0596
Merge pull request #1 from patrick-knight/patrick-knight-patch-1
patrick-knight Aug 5, 2025
4cf29f9
feat: add GitHub Enterprise tools and update discussions repo paramet…
patrick-knight Aug 5, 2025
559ab48
Update pkg/github/tools.go
patrick-knight Aug 5, 2025
aaad977
Update pkg/github/custom_properties.go
patrick-knight Aug 5, 2025
e5fa6f7
Update pkg/github/custom_properties.go
patrick-knight Aug 5, 2025
02e09c3
Update pkg/github/custom_properties.go
patrick-knight Aug 5, 2025
ee41661
fix: ensure proper return values in custom properties functions
patrick-knight Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: ensure proper return values in custom properties functions
  • Loading branch information
@patrick-knight
patrick-knight committed Aug 5, 2025
commit ee4166109bde8775e7d488911bafb67656e52000
6 changes: 3 additions & 3 deletions pkg/github/custom_properties.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func GetRepositoryCustomProperties(getClient GetClientFn, t translations.Transla
return mcp.NewToolResultError(err.Error()), nil
}

return MarshalledTextResult(props)
return MarshalledTextResult(props), nil
}
}

Expand Down Expand Up @@ -124,7 +124,7 @@ func GetOrganizationCustomProperties(getClient GetClientFn, t translations.Trans
if err != nil {
return mcp.NewToolResultError(err.Error()), nil
}
return MarshalledTextResult("Organization custom properties for "+org, props)
return MarshalledTextResult(props), nil
}
}

Expand Down Expand Up @@ -191,7 +191,7 @@ func GetEnterpriseCustomProperties(getClient GetClientFn, t translations.Transla
if err != nil {
return mcp.NewToolResultError(err.Error()), nil
}
return MarshalledTextResult(props)
return MarshalledTextResult(props), nil
}
}

Expand Down
7 changes: 1 addition & 6 deletions pkg/github/tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,7 @@ func DefaultToolsetGroup(readOnly bool, getClient GetClientFn, getGQLClient GetG
AddWriteTools(func() server.ServerTool {
tool, handler := CreateOrUpdateRepositoryCustomProperties(getClient, t)
return toolsets.NewServerTool(tool, handler)
AddReadTools(
toolsets.NewServerTool(GetRepositoryCustomProperties(getClient, t)),
).
AddWriteTools(
toolsets.NewServerTool(CreateOrUpdateRepositoryCustomProperties(getClient, t)),
)
}())
Comment thread
patrick-knight marked this conversation as resolved.
issues := toolsets.NewToolset("issues", "GitHub Issues related tools").
AddReadTools(
toolsets.NewServerTool(GetIssue(getClient, t)),
Expand Down