Skip to content

Refactor feature flags to use functional availability rules #3166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamMorrowDrums merged 16 commits into from
Sep 3, 2026
Merged

Refactor feature flags to use functional availability rules #3166

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
cee49f5
refactor(features)!: use functional availability rules
SamMorrowDrums Aug 27, 2026
0e91509
fix(features): address resolver review feedback
SamMorrowDrums Aug 27, 2026
b33585e
fix(features): harden request resolution
SamMorrowDrums Sep 1, 2026
db9b353
test(features): preserve query flag coverage after rebase
SamMorrowDrums Sep 1, 2026
af10d20
fix(features): close cycle and ownership gaps
SamMorrowDrums Sep 1, 2026
4ea1555
fix(features): share registration resolution
SamMorrowDrums Sep 1, 2026
7921f78
fix(features): isolate metadata and validate variants
SamMorrowDrums Sep 2, 2026
e470871
fix(inventory): isolate tool lookup results
SamMorrowDrums Sep 2, 2026
e070a77
fix(inventory): normalize owned metadata
SamMorrowDrums Sep 2, 2026
f479917
fix(inventory): preserve metadata number precision
SamMorrowDrums Sep 2, 2026
ac54ad6
refactor(features): simplify lazy resolution
SamMorrowDrums Sep 2, 2026
875a1f6
fix(features): fail nested checker resolution closed
SamMorrowDrums Sep 2, 2026
0baddbf
docs(features): describe lazy rule resolution
SamMorrowDrums Sep 3, 2026
7f89402
perf(features): filter static exclusions first
SamMorrowDrums Sep 3, 2026
0d8baad
fix(features): defer unknown client availability
SamMorrowDrums Sep 3, 2026
382a534
fix(features): preserve unavailable call errors
SamMorrowDrums Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(features): defer unknown client availability 
Apply pre-feature protocol and elicitation filtering only when stateless request metadata is known, leaving existing middleware to enforce unknown contexts.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 1e4a1ca6-53f7-4158-af22-35d2448d0b13
  • Loading branch information
@SamMorrowDrums
SamMorrowDrums and Copilot committed Sep 3, 2026
commit 0d8baadcfe37a4f083d53ef070e7700300429e16
10 changes: 6 additions & 4 deletions pkg/inventory/filters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,12 @@ func (r *Inventory) isToolEnabled(ctx context.Context, tool *ServerTool, feature
return false
}
if availability := tool.availability(); !availability.unrestricted() {
if info, ok := ghcontext.MCPMethod(ctx); ok &&
(info.Method == MCPMethodToolsList || info.Method == MCPMethodToolsCall) &&
!toolAvailable(info.ProtocolVersion, info.ClientCapabilities, availability) {
return false
if info, ok := ghcontext.MCPMethod(ctx); ok && (info.Method == MCPMethodToolsList || info.Method == MCPMethodToolsCall) {
known := (availability.minimumProtocolVersion == "" || info.ProtocolVersion != "") &&
(availability.requiredElicitationMode == "" || info.ClientCapabilities != nil)
if known && !toolAvailable(info.ProtocolVersion, info.ClientCapabilities, availability) {
return false
}
}
}
// 4. Check feature availability.
Expand Down
5 changes: 5 additions & 0 deletions pkg/inventory/registry_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1959,6 +1959,11 @@ func TestMCPAvailabilityRunsBeforeFeatureChecks(t *testing.T) {
})
require.Len(t, inv.AvailableTools(ctx), 2)
require.Equal(t, 1, calls)

calls = 0
ctx = ghcontext.WithMCPMethodInfo(context.Background(), &ghcontext.MCPMethodInfo{Method: method})
require.Len(t, inv.AvailableTools(ctx), 2)
require.Equal(t, 1, calls)
})
}
}
Expand Down
Loading