Skip to content

Spell perPage the same way in every paginated tool #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamMorrowDrums merged 2 commits into from
Sep 2, 2026
Merged

Spell perPage the same way in every paginated tool #3142

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7942bc9
Fix perPage parameter name in actions_list schema
karpovantonme Aug 22, 2026
2c4b2a3
fix(projects): spell the page size the way the rest of the server does
karpovantonme Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix perPage parameter name in actions_list schema 
The schema declared per_page while the handler reads pagination through
OptionalPaginationParams, which looks for perPage, so the value was
always dropped and perPage fell back to the default 30.
  • Loading branch information
@karpovantonme
karpovantonme committed Aug 27, 2026
commit 7942bc9f29c3fb7753487eb5e019f37427006759
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,7 +631,7 @@ The following sets of tools are available:
- `method`: The action to perform (string, required)
- `owner`: Repository owner (string, required)
- `page`: Page number for pagination (default: 1) (number, optional)
- `per_page`: Results per page for pagination (default: 30, max: 100) (number, optional)
- `perPage`: Results per page for pagination (default: 30, max: 100) (number, optional)
- `repo`: Repository name (string, required)
- `resource_id`: The unique identifier of the resource. This will vary based on the "method" provided, so ensure you provide the correct ID:
- Do not provide any resource ID for 'list_workflows' method.
Expand Down
2 changes: 1 addition & 1 deletion pkg/github/__toolsnaps__/actions_list.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"minimum": 1,
"type": "number"
},
"per_page": {
"perPage": {
"description": "Results per page for pagination (default: 30, max: 100)",
"maximum": 100,
"minimum": 1,
Expand Down
2 changes: 1 addition & 1 deletion pkg/github/actions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ Use this tool to list workflows in a repository, or list workflow runs, jobs, an
Description: "Page number for pagination (default: 1)",
Minimum: jsonschema.Ptr(1.0),
},
"per_page": {
"perPage": {
Type: "number",
Description: "Results per page for pagination (default: 30, max: 100)",
Minimum: jsonschema.Ptr(1.0),
Expand Down