Skip to content

feat(governance): add custom properties tools #2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamMorrowDrums merged 8 commits into from
Sep 3, 2026
Merged

feat(governance): add custom properties tools #2992

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c0fe969
feat(governance): add custom properties tools with multi-level scope …
SamMorrowDrums Aug 27, 2026
cd6347c
fix(governance): validate custom property values
SamMorrowDrums Sep 1, 2026
c9ade1f
fix(governance): reject unknown custom property fields
SamMorrowDrums Sep 2, 2026
80e310c
fix(governance): validate custom properties by level
SamMorrowDrums Sep 2, 2026
8e921ba
fix(governance): preserve custom property item type
SamMorrowDrums Sep 2, 2026
3463a42
fix(governance): preserve partial property updates
SamMorrowDrums Sep 2, 2026
1453e3c
chore: regenerate license files
github-actions[bot] Sep 3, 2026
725edf3
chore: rerun checks after license regeneration
SamMorrowDrums Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(governance): preserve custom property item type 
Co-authored-by: Patrick Knight <patrick-knight@github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 1e886867-a922-419a-b02c-ac643716aea8
  • Loading branch information
@SamMorrowDrums @patrick-knight
3 people committed Sep 3, 2026
commit 8e921ba08be29e2272217f0a828fd2e0772555e8
3 changes: 2 additions & 1 deletion pkg/github/__toolsnaps__/custom_properties_write.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,8 @@
],
"type": "object"
}
]
],
"type": "object"
},
"type": "array"
},
Expand Down
1 change: 1 addition & 0 deletions pkg/github/custom_properties.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ func CustomPropertiesWrite(t translations.TranslationHelperFunc) inventory.Serve
Type: "array",
Description: "The custom properties to create or update. At the repository level each item assigns a value ('property_name' and 'value'); at the organization and enterprise levels each item defines the schema ('property_name' and 'value_type', plus optional definition fields).",
Comment thread
Copilot marked this conversation as resolved.
Items: &jsonschema.Schema{
Type: "object",
OneOf: []*jsonschema.Schema{
customPropertyValueSchema(),
customPropertyDefinitionSchema(),
Expand Down
1 change: 1 addition & 0 deletions pkg/github/custom_properties_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ func Test_CustomPropertiesWrite(t *testing.T) {

t.Run("property items use level-specific schemas", func(t *testing.T) {
itemSchema := schema.Properties["properties"].Items
assert.Equal(t, "object", itemSchema.Type)
require.Len(t, itemSchema.OneOf, 2)
valueItemSchema := itemSchema.OneOf[0]
definitionItemSchema := itemSchema.OneOf[1]
Expand Down