Skip to content

Enrich issue_read get with hierarchy relationship signals #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kerobbi merged 7 commits into from
Jul 7, 2026
Merged

Enrich issue_read get with hierarchy relationship signals #2764

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a596146
Enrich issue_read get with hierarchy relationship signals
zwick Jun 24, 2026
85709bf
Tighten hierarchy tool wording
zwick Jun 26, 2026
e2c1a6e
Omit unverified parent under lockdown instead of redacting title
zwick Jun 26, 2026
4d78776
Restore explicit issue read query matcher
zwick Jun 26, 2026
71b3b4f
Omit hierarchy flags when enrichment fails
zwick Jun 30, 2026
cd3e9ac
Address hierarchy review nits
zwick Jun 30, 2026
215e10a
Merge branch 'main' into zwick-enrich-issue-read-hierarchy
kerobbi Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Restore explicit issue read query matcher 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  • Loading branch information
@zwick
zwick and Copilot committed Jun 30, 2026
commit 4d787765e714e6425e0e85199efda597a1fe5336
14 changes: 6 additions & 8 deletions pkg/github/issues_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,18 +49,16 @@ func newRepoAccessHTTPClient() *http.Client {
return &http.Client{Transport: &repoAccessMockTransport{responses: responses}}
}

const issueReadEnrichmentQueryString = "query($ids:[ID!]!){nodes(ids: $ids){... on Issue{id,issueFieldValues(first: 25){nodes{__typename,... on IssueFieldDateValue{field{... on IssueFieldDate{name,fullDatabaseId},... on IssueFieldNumber{name,fullDatabaseId},... on IssueFieldSingleSelect{name,fullDatabaseId},... on IssueFieldText{name,fullDatabaseId}},value},... on IssueFieldNumberValue{field{... on IssueFieldDate{name,fullDatabaseId},... on IssueFieldNumber{name,fullDatabaseId},... on IssueFieldSingleSelect{name,fullDatabaseId},... on IssueFieldText{name,fullDatabaseId}},valueNumber: value},... on IssueFieldSingleSelectValue{field{... on IssueFieldDate{name,fullDatabaseId},... on IssueFieldNumber{name,fullDatabaseId},... on IssueFieldSingleSelect{name,fullDatabaseId},... on IssueFieldText{name,fullDatabaseId}},value},... on IssueFieldTextValue{field{... on IssueFieldDate{name,fullDatabaseId},... on IssueFieldNumber{name,fullDatabaseId},... on IssueFieldSingleSelect{name,fullDatabaseId},... on IssueFieldText{name,fullDatabaseId}},value}}},parent{number,title,state,url,author{login},repository{nameWithOwner}},subIssuesSummary{total,completed,percentCompleted}}}}"

// newIssueReadEnrichmentMatcher builds a matcher for the issue_read `get` enrichment query for a
// single issue node ID. The query string is constructed from the typed githubv4.ID variable so the
// generated `$ids:[ID!]!` declaration matches the real client, while the comparison variables are
// reassigned to the []any shape the request body decodes into so equality holds.
// single issue node ID.
func newIssueReadEnrichmentMatcher(nodeID string, response githubv4mock.GQLResponse) githubv4mock.Matcher {
matcher := githubv4mock.NewQueryMatcher(
issueReadEnrichmentQuery{},
map[string]any{"ids": []githubv4.ID{githubv4.ID(nodeID)}},
return githubv4mock.NewQueryMatcher(
issueReadEnrichmentQueryString,
map[string]any{"ids": []any{nodeID}},
response,
)
matcher.Variables = map[string]any{"ids": []any{nodeID}}
return matcher
}

func (rt *repoAccessMockTransport) RoundTrip(req *http.Request) (*http.Response, error) {
Expand Down
Loading