Skip to content

Annotate read tools with ifc labels #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamMorrowDrums merged 5 commits into from
Jun 11, 2026
Merged

Annotate read tools with ifc labels #2671

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6012e53
Annotate read tools with ifc labels
JoannaaKL Jun 11, 2026
a443896
Dont automatically enable IFCLabels in insiders mode
JoannaaKL Jun 11, 2026
2813f07
ifc: don't label unpublished repo advisories as public
JoannaaKL Jun 11, 2026
fcffda3
ifc: fix confidentiality under-classification in releases, collaborat…
JoannaaKL Jun 11, 2026
ace06e3
ifc: document why list results use one joined label, not per-item
JoannaaKL Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ifc: document why list results use one joined label, not per-item 
Explain on LabelSearchIssues (and cross-ref from LabelGistList) that a tool
result is delivered as one opaque payload and the IFC engine makes one
allow/deny decision per flow at egress, so the only sound bound for a list is
the meet of every item's label. Per-item labels would only be load-bearing if
the engine could partition a result and route items to different sinks; until
then they would invite unsafe declassification of a public item that arrived
alongside private data. Doc-only change.
  • Loading branch information
@JoannaaKL
JoannaaKL committed Jun 11, 2026
commit ace06e38898e3f0d64e469ce31c21d55960dcd2e
13 changes: 13 additions & 0 deletions pkg/ifc/ifc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,16 @@ func LabelGetFileContents(isPrivate bool) SecurityLabel {
//
// An empty result set is treated as public-untrusted (no repository data is
// leaked).
//
// Why a single joined label rather than one label per item: a tool result is
// delivered as one opaque payload (a single content block) and the IFC engine
// makes one allow/deny decision per flow at egress. Once the items share a
// buffer in the agent's context they can be copied anywhere together, so the
// only sound bound for the whole result is the meet of every item's label.
// Per-item labels would only become load-bearing if the enforcement engine
// could partition a result and route individual items to different sinks;
// until then they would invite unsafe declassification of a "public" item that
// actually arrived alongside private data.
func LabelSearchIssues(repoVisibilities []bool) SecurityLabel {
for _, isPrivate := range repoVisibilities {
if isPrivate {
Expand Down Expand Up @@ -268,6 +278,9 @@ func LabelGist(isPublic bool) SecurityLabel {
// Integrity is untrusted (user-authored content). Confidentiality follows the
// IFC meet: if any gist in the result is secret the joined label is private;
// otherwise public. An empty result is treated as public-untrusted.
//
// See LabelSearchIssues for why list results carry a single joined label
// rather than one label per item.
func LabelGistList(gistVisibilities []bool) SecurityLabel {
for _, isPublic := range gistVisibilities {
if !isPublic {
Expand Down
Loading