Skip to content

feat: add GitHub App authentication support #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pyama86 wants to merge 9 commits into from
Closed

feat: add GitHub App authentication support #2562

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
db89352
feat: add GitHub App authentication support
pyama86 May 27, 2026
f3ad678
fix: use direct NewClient calls instead of gogithub.Option slice
pyama86 May 27, 2026
6799ef5
fix: address Copilot review feedback
pyama86 May 28, 2026
a808385
feat: support GitHub App authentication in HTTP mode
go-kazuhiko-yamashita Jun 8, 2026
1413842
Merge branch 'main' into feat/github-app-auth
pyama86 Jun 10, 2026
e62232f
Merge branch 'main' into feat/github-app-auth
pyama86 Jun 15, 2026
e9625e7
Merge upstream main into feat/github-app-auth
pyama86 Jun 27, 2026
fe2da47
Merge remote-tracking branch 'origin/feat/github-app-auth' into feat/…
pyama86 Jun 27, 2026
7fab774
Move GitHub App docs out of README
pyama86 Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use direct NewClient calls instead of gogithub.Option slice 
gogithub.Option is not an exported type, so we cannot store options
in a slice. Use separate NewClient calls for each auth path instead.
  • Loading branch information
@pyama86
pyama86 committed May 27, 2026
commit f3ad678ceb6510c02bf127ccc3b499ff868a1620
19 changes: 12 additions & 7 deletions internal/ghmcp/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,19 @@ func createGitHubClients(cfg github.MCPServerConfig, apiHost utils.APIHostResolv
Transport: baseTransport,
Agent: fmt.Sprintf("github-mcp-server/%s", cfg.Version),
}
restClientOpts := []gogithub.Option{
gogithub.WithHTTPClient(&http.Client{Transport: restUATransport}),
gogithub.WithEnterpriseURLs(restURL.String(), uploadURL.String()),
}
if authTransport == nil {
restClientOpts = append(restClientOpts, gogithub.WithAuthToken(cfg.Token))
var restClient *gogithub.Client
if authTransport != nil {
restClient, err = gogithub.NewClient(
gogithub.WithHTTPClient(&http.Client{Transport: restUATransport}),
gogithub.WithEnterpriseURLs(restURL.String(), uploadURL.String()),
)
} else {
restClient, err = gogithub.NewClient(
gogithub.WithHTTPClient(&http.Client{Transport: restUATransport}),
gogithub.WithAuthToken(cfg.Token),
gogithub.WithEnterpriseURLs(restURL.String(), uploadURL.String()),
)
}
restClient, err := gogithub.NewClient(restClientOpts...)
if err != nil {
return nil, fmt.Errorf("failed to create REST client: %w", err)
}
Expand Down