Skip to content

fix: guard CompletionsHandler against nil params/ref #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamMorrowDrums merged 3 commits into from
May 19, 2026
Merged

fix: guard CompletionsHandler against nil params/ref #2502

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c916d2
fix: guard CompletionsHandler against nil params/ref
SamMorrowDrums May 19, 2026
8efe6ec
Align error wording with repo convention
SamMorrowDrums May 19, 2026
4cb84ac
Merge branch 'main' into sammorrowdrums/fix-completions-nil-deref
SamMorrowDrums May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Align error wording with repo convention 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  • Loading branch information
@SamMorrowDrums
SamMorrowDrums and Copilot committed May 19, 2026
commit 8efe6ec0edf78693058c806b79ab127c5ed6a662
2 changes: 1 addition & 1 deletion pkg/github/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ func NewServer(version, name, title string, opts *mcp.ServerOptions) *mcp.Server
func CompletionsHandler(getClient GetClientFn) func(ctx context.Context, req *mcp.CompleteRequest) (*mcp.CompleteResult, error) {
return func(ctx context.Context, req *mcp.CompleteRequest) (*mcp.CompleteResult, error) {
if req == nil || req.Params == nil || req.Params.Ref == nil {
return nil, fmt.Errorf("invalid request: missing ref parameter")
return nil, fmt.Errorf("missing required parameter: ref")
}
switch req.Params.Ref.Type {
case "ref/resource":
Expand Down
2 changes: 1 addition & 1 deletion pkg/github/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ func TestCompletionsHandler_RejectsMissingRef(t *testing.T) {
result, err := handler(context.Background(), tc.req)
require.Error(t, err)
assert.Nil(t, result)
assert.Contains(t, err.Error(), "missing ref parameter")
assert.Contains(t, err.Error(), "missing required parameter: ref")
})
}
}
Loading