Skip to content

fix: additionalProperties in push_files schema (#2011) #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamMorrowDrums merged 2 commits into from
Mar 29, 2026
Merged

fix: additionalProperties in push_files schema (#2011) #2257

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
676a588
fix: additionalProperties in push_files schema (#2011)
sierikov Mar 24, 2026
f30062b
Merge branch 'main' into fix/2011-push-files-schema
SamMorrowDrums Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: additionalProperties in push_files schema (#2011) 
Some MCP clients require array item schemas to explicitly set
`additionalProperties: false`. Without this, `push_files` calls will fail.

Fixes #2011
Research and fix was initially done by @04cb
  • Loading branch information
@sierikov
sierikov committed Mar 24, 2026
commit 676a5889305feca90e53b78d4c455eb5967094eb
1 change: 1 addition & 0 deletions pkg/github/__toolsnaps__/push_files.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"files": {
"description": "Array of file objects to push, each object with path (string) and content (string)",
"items": {
"additionalProperties": false,
"properties": {
"content": {
"description": "file content",
Expand Down
3 changes: 2 additions & 1 deletion pkg/github/repositories.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1233,7 +1233,8 @@ func PushFiles(t translations.TranslationHelperFunc) inventory.ServerTool {
Type: "array",
Description: "Array of file objects to push, each object with path (string) and content (string)",
Items: &jsonschema.Schema{
Type: "object",
Type: "object",
AdditionalProperties: &jsonschema.Schema{Not: &jsonschema.Schema{}},
Properties: map[string]*jsonschema.Schema{
"path": {
Type: "string",
Expand Down
Loading