Skip to content

fix: add MCP initialize handshake to mcpcurl #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamMorrowDrums merged 3 commits into from
May 31, 2026
Merged

fix: add MCP initialize handshake to mcpcurl #2009

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae5bc07
fix: add MCP initialize handshake to mcpcurl
ra-n-dom Feb 13, 2026
9d5a700
fix: surface JSON-RPC error responses in mcpcurl
ra-n-dom Feb 14, 2026
26573e9
review: switch cleanup to defer
7cea4701430283a4267f819a278be05d_pingqa May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: surface JSON-RPC error responses in mcpcurl 
readJSONRPCResponse now checks for an "error" field in responses
and returns a descriptive error instead of silently passing it through.
  • Loading branch information
@ra-n-dom @SamMorrowDrums
ra-n-dom authored and SamMorrowDrums committed May 31, 2026
commit 9d5a7002f12d8af9d36bcb07fa5e21c06bc1097e
3 changes: 3 additions & 0 deletions cmd/mcpcurl/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,6 +503,9 @@ func readJSONRPCResponse(scanner *bufio.Scanner) (string, error) {
return "", fmt.Errorf("failed to parse JSON-RPC message: %w", err)
}
if _, hasID := msg["id"]; hasID {
if errField, hasErr := msg["error"]; hasErr {
return "", fmt.Errorf("server returned error: %s", string(errField))
}
return line, nil
}
// No "id" — this is a notification, skip it
Expand Down
17 changes: 17 additions & 0 deletions cmd/mcpcurl/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,23 @@ func TestReadJSONRPCResponse_InvalidJSON(t *testing.T) {
}
}

func TestReadJSONRPCResponse_ServerError(t *testing.T) {
t.Parallel()
input := `{"jsonrpc":"2.0","id":1,"error":{"code":-32601,"message":"method not found"}}` + "\n"
scanner := bufio.NewScanner(strings.NewReader(input))

_, err := readJSONRPCResponse(scanner)
if err == nil {
t.Fatal("expected error for server error response, got nil")
}
if !strings.Contains(err.Error(), "server returned error") {
t.Fatalf("expected 'server returned error', got: %v", err)
}
if !strings.Contains(err.Error(), "method not found") {
t.Fatalf("expected error to contain server message, got: %v", err)
}
}

func TestBuildInitializeRequest(t *testing.T) {
t.Parallel()
got, err := buildInitializeRequest()
Expand Down
Loading