Skip to content

Add retry logic with jitter for sub_issue_write to handle parallel calls #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add retry logic with jitter for sub_issue_write to handle parallel calls #1843

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
aa81e3d
Initial plan
Copilot Jan 19, 2026
fd50a3e
Add retry logic with jitter for sub_issue_write to handle parallel calls
Copilot Jan 19, 2026
b8f0b13
Address code review feedback: simplify error checking and fix logic
Copilot Jan 19, 2026
3f87488
Fix response body handling and remove unreachable code
Copilot Jan 19, 2026
6e0e72a
Fix defer placement for response body closing
Copilot Jan 19, 2026
7e0380c
Fix response body handling and improve thread safety in tests
Copilot Jan 19, 2026
d3cf18d
Use atomic operations for thread-safe test counter
Copilot Jan 19, 2026
9469022
Add named constants for jitter and improve error diagnostics
Copilot Jan 19, 2026
8e0a81f
Fix resource leak: close response body in success path
Copilot Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix resource leak: close response body in success path 
Co-authored-by: SamMorrowDrums <4811358+SamMorrowDrums@users.noreply.github.com>
  • Loading branch information
@SamMorrowDrums
Copilot and SamMorrowDrums committed Jan 20, 2026
commit 8e0a81fb76f7d8854f70c98f009f7745b1fc8f07
1 change: 1 addition & 0 deletions pkg/github/issues.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,6 +831,7 @@ func AddSubIssue(ctx context.Context, client *github.Client, owner string, repo

// Success case
if err == nil && resp.StatusCode == http.StatusCreated {
_ = resp.Body.Close()
r, err := json.Marshal(subIssue)
if err != nil {
return nil, fmt.Errorf("failed to marshal response: %w", err)
Expand Down