Skip to content

Replace go-github-mock with stretchr/testify for actions/issues/projects tests #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoannaaKL merged 15 commits into from
Jan 6, 2026
Merged

Replace go-github-mock with stretchr/testify for actions/issues/projects tests #1737

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e46b48f
Initial plan
Copilot Jan 5, 2026
c192013
migrate tests from go-github-mock to internal testify-based mock
Copilot Jan 5, 2026
eb9480e
address feedback in testmock helper
Copilot Jan 5, 2026
9627085
tweak testmock path matching edge case
Copilot Jan 5, 2026
65ff757
refine testmock options and path matching
Copilot Jan 5, 2026
4f622c9
simplify matchPath and document delete endpoint
Copilot Jan 5, 2026
d485855
Replace go-github-mock usage in tests with shared HTTP mock helper
Copilot Jan 5, 2026
766e440
Merge branch 'main' into copilot/work-on-issue-1492-comment
JoannaaKL Jan 5, 2026
2010cb6
Replace go-github-mock usage in tests with shared HTTP mock helper
Copilot Jan 5, 2026
d76cda5
fix tests and lint after mock cleanup
Copilot Jan 5, 2026
698a254
Merge branch 'main' into copilot/work-on-issue-1492-comment
JoannaaKL Jan 5, 2026
a087607
Remove import completely
JoannaaKL Jan 5, 2026
c85cbf3
Partial removal in repositories_test.go
JoannaaKL Jan 5, 2026
20c45d9
Final removal
JoannaaKL Jan 6, 2026
7f874eb
Merge branch 'main' into copilot/work-on-issue-1492-comment
JoannaaKL Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address feedback in testmock helper 
Co-authored-by: JoannaaKL <67866556+JoannaaKL@users.noreply.github.com>
  • Loading branch information
@JoannaaKL
Copilot and JoannaaKL committed Jan 5, 2026
commit eb9480e5ee3021a0ba7cd52423030dcde6724379
23 changes: 15 additions & 8 deletions pkg/github/testmock/testmock.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,19 @@ func WithRequestMatch(pattern EndpointPattern, response any) Option {
w.WriteHeader(http.StatusOK)
switch body := response.(type) {
case string:
_, _ = w.Write([]byte(body))
if _, err := w.Write([]byte(body)); err != nil {
panic(err)
}
default:
if body == nil {
return
}
if data, err := json.Marshal(body); err == nil {
_, _ = w.Write(data)
data, err := json.Marshal(body)
if err != nil {
panic(err)
}
if _, err := w.Write(data); err != nil {
panic(err)
}
}
}
Expand Down Expand Up @@ -64,8 +70,8 @@ func (t *transport) RoundTrip(req *http.Request) (*http.Response, error) {
}

for patternKey, handler := range t.handlers {
method, pattern := splitKey(patternKey)
if method != req.Method {
method, pattern, ok := splitKey(patternKey)
if !ok || method != req.Method {
continue
}
if matchPath(pattern, req.URL.Path) {
Expand Down Expand Up @@ -119,12 +125,12 @@ func key(p EndpointPattern) string {
return strings.ToUpper(p.Method) + " " + p.Pattern
}

func splitKey(k string) (method, pattern string) {
func splitKey(k string) (method, pattern string, ok bool) {
parts := strings.SplitN(k, " ", 2)
if len(parts) == 2 {
return parts[0], parts[1]
return parts[0], parts[1], true
}
return "", ""
return "", "", false
}

func matchPath(pattern, path string) bool {
Expand All @@ -151,6 +157,7 @@ func matchPath(pattern, path string) bool {
}

// MustMarshal marshals the provided value or panics on error.
// Use this in tests when marshaling test data should halt execution immediately on failure.
func MustMarshal(v any) []byte {
data, err := json.Marshal(v)
if err != nil {
Expand Down