Skip to content

Add raw client error annotation and annotate GetFileContents #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattdholloway merged 15 commits into from
Dec 19, 2025
Merged

Add raw client error annotation and annotate GetFileContents #1570

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8fc11ae
Add raw client error annotation and annotate GetFileContents
omgitsads Dec 10, 2025
234565b
Track response.
omgitsads Dec 10, 2025
dd7f537
add raw errors to context
mattdholloway Dec 15, 2025
831b908
Merge branch 'main' into raw-client-error-annotation
mattdholloway Dec 15, 2025
c12abc4
add raw api error test
mattdholloway Dec 15, 2025
3727f68
Merge branch 'main' into raw-client-error-annotation
mattdholloway Dec 15, 2025
2b7d781
Update pkg/errors/error.go
mattdholloway Dec 15, 2025
8dad5c2
Merge branch 'main' into raw-client-error-annotation
mattdholloway Dec 16, 2025
84b1f0c
Merge remote-tracking branch 'origin/main' into raw-client-error-anno…
mattdholloway Dec 17, 2025
349877f
Add blank line after Error() method for readability
mattdholloway Dec 17, 2025
0a6760d
Merge branch 'main' into raw-client-error-annotation
mattdholloway Dec 17, 2025
16a1445
add NewGitHubRawAPIErrorResponse back
mattdholloway Dec 17, 2025
fe976d4
Merge branch 'main' into raw-client-error-annotation
mattdholloway Dec 17, 2025
a1b6d7b
Merge branch 'main' into raw-client-error-annotation
mattdholloway Dec 18, 2025
9d3173f
Merge branch 'main' into raw-client-error-annotation
mattdholloway Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add NewGitHubRawAPIErrorResponse back
  • Loading branch information
@mattdholloway
mattdholloway committed Dec 17, 2025
commit 16a1445db95180f2a10e6be6b0adc1c44ca055be
9 changes: 9 additions & 0 deletions pkg/errors/error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,15 @@ func NewGitHubGraphQLErrorResponse(ctx context.Context, message string, err erro
return utils.NewToolResultErrorFromErr(message, err)
}

// NewGitHubRawAPIErrorResponse returns an mcp.NewToolResultError and retains the error in the context for access via middleware
func NewGitHubRawAPIErrorResponse(ctx context.Context, message string, resp *http.Response, err error) *mcp.CallToolResult {
rawErr := newGitHubRawAPIError(message, resp, err)
if ctx != nil {
_, _ = addRawAPIErrorToContext(ctx, rawErr) // Explicitly ignore error for graceful handling
}
return utils.NewToolResultErrorFromErr(message, err)
}

// NewGitHubAPIStatusErrorResponse handles cases where the API call succeeds (err == nil)
// but returns an unexpected HTTP status code. It creates a synthetic error from the
// status code and response body, then records it in context for observability tracking.
Expand Down