Skip to content

Add case-sensitive KV support #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zerowidth wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add case-sensitive KV support #54

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
807e15b
Pin rails 6 to latest release
zerowidth Mar 22, 2021
631a581
Make migration name and table name parameters for easier customization
zerowidth Mar 22, 2021
fdd6704
Update KV to support case-insensitive fetches
zerowidth Mar 22, 2021
7effa7f
Update README to mention case-insensitivity
zerowidth Mar 22, 2021
3c5a290
bump version to 0.5.1
zerowidth Mar 22, 2021
400151c
Add case-sensitive generator option
zerowidth Mar 22, 2021
b510f08
Add case-sensitive config option for KV
zerowidth Mar 22, 2021
e616681
Generate migration name automatically to match filename
zerowidth Mar 22, 2021
6c09dea
Add --table-name and case-insensitivity to README
zerowidth Mar 22, 2021
eda75f3
Bump version to 0.6.0
zerowidth Mar 22, 2021
a02f6c5
Pin rails version in travis too
zerowidth Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update KV to support case-insensitive fetches
  • Loading branch information
@zerowidth
zerowidth committed Mar 22, 2021
commit fdd67046d9adfc290a5cb062b496eb5b6a6d4705
3 changes: 2 additions & 1 deletion lib/github/kv.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@ def mget(keys)
SELECT `key`, value FROM #{@table_name} WHERE `key` IN :keys AND (`expires_at` IS NULL OR `expires_at` > :now)
SQL

keys.map { |key| kvs[key] }
kvs.keys.each { |key| kvs[key.downcase] = kvs[key] }
keys.map { |key| kvs[key.downcase] }
}
end

Expand Down
12 changes: 12 additions & 0 deletions test/github/kv_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,18 @@ def test_mget_and_mset
assert_equal ["2", "1"], @kv.mget(["b", "a"]).value!
end

def test_get_and_set_case_insensitive
assert_nil @kv.get("foo").value!

@kv.set "foo", "lowercase"
assert_equal "lowercase", @kv.get("foo").value!
assert_equal "lowercase", @kv.get("FOO").value!

@kv.set "FOO", "uppercase"
assert_equal "uppercase", @kv.get("foo").value!
assert_equal "uppercase", @kv.get("FOO").value!
end

def test_get_failure
ActiveRecord::Base.connection.stubs(:select_all).raises(Errno::ECONNRESET)

Expand Down