Skip to content

Fix failing unit tests: resolve MCP server dependencies, config generation bugs, and JavaScript test issues #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 5 commits into from
Sep 20, 2025
Merged

Fix failing unit tests: resolve MCP server dependencies, config generation bugs, and JavaScript test issues #943

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
083569b
Initial plan
Copilot Sep 20, 2025
8ae8dbf
Fix failing tests: add missing env vars and fix typos in config gener…
Copilot Sep 20, 2025
c15eeb7
Fix JavaScript tests: add missing exec imports and update test mocks
Copilot Sep 20, 2025
b69fc12
Revert upload-asset config key to upload-assets as requested
Copilot Sep 20, 2025
9a049ac
Remove exec imports from JavaScript files as exec is built-in to acti…
Copilot Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert upload-asset config key to upload-assets as requested 
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
  • Loading branch information
@pelikhan
Copilot and pelikhan committed Sep 20, 2025
commit b69fc1271e259a4d826961e131b03c5a2db943ca
5 changes: 4 additions & 1 deletion .github/workflows/ci-doctor.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

224 changes: 220 additions & 4 deletions .github/workflows/dev.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/workflow/publish_assets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type UploadAssetsConfig struct {

// parseUploadAssetConfig handles upload-asset configuration
func (c *Compiler) parseUploadAssetConfig(outputMap map[string]any) *UploadAssetsConfig {
if configData, exists := outputMap["upload-asset"]; exists {
if configData, exists := outputMap["upload-assets"]; exists {
config := &UploadAssetsConfig{
BranchName: "assets/${{ github.workflow }}", // Default branch name
MaxSizeKB: 10240, // Default 10MB
Expand Down
2 changes: 1 addition & 1 deletion pkg/workflow/publish_assets_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ func TestParseUploadAssetConfig(t *testing.T) {
{
name: "upload-asset config with custom values",
input: map[string]any{
"upload-asset": map[string]any{
"upload-assets": map[string]any{
"branch": "my-assets/${{ github.event.repository.name }}",
"max-size": 5120,
"allowed-exts": []any{".jpg", ".png", ".txt"},
Expand Down