Repository navigation
Conversation
…ment types - Add JSDoc type annotations for all major functions and variables - Add type annotations for parameters, return values, and data structures - Add comprehensive documentation comments with type information - Map tool types to corresponding safe output interfaces from TypeScript definitions - Ensure type checking passes while maintaining all existing functionality - Add type annotations for JSON-RPC message handling and MCP tool validation Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Apply types from the safe output in the JavaScript types.ts to the safe output MCP server so that it type checks. Use JavaScript comment types.
Apply TypeScript types to safe output MCP server using JavaScript comment types
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies types from the TypeScript definition file (
pkg/workflow/js/types/safe-outputs.d.ts) to the safe output MCP server (pkg/workflow/js/safe_outputs_mcp_server.cjs) using JSDoc comment types to improve type safety and developer experience.Problem
The safe output MCP server was missing type annotations, making it difficult for developers to understand the expected data structures and function signatures. While TypeScript definitions existed for safe output types, they weren't being utilized in the CommonJS implementation.
Solution
Added comprehensive JSDoc type annotations throughout the MCP server implementation:
TOOLSconfiguration object are properly typedcreate-issue→CreateIssueItemcreate-discussion→CreateDiscussionItemadd-comment→AddCommentItemKey Changes
appendSafeOutput(),defaultHandler(),handleMessage()ReadBufferclass and its methods for stdin message processingwriteMessage(),replyResult(),replyError()Benefits
Validation
npm run typecheck)This change improves the development experience while maintaining full backward compatibility.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.contoso.com/tmp/go-build662510319/b305/cli.test -test.testlogfile=/tmp/go-build662510319/b305/testlog.txt -test.paniconexit0 -test.v=true -test.timeout=3m0s(dns block)/tmp/go-build4276602074/b305/cli.test -test.testlogfile=/tmp/go-build4276602074/b305/testlog.txt -test.paniconexit0 -test.v=true -test.timeout=3m0s(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.