Skip to content

refactor(workqueue): centralize assignment receipt projections #67649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 4 commits into from
Oct 11, 2026
Merged

refactor(workqueue): centralize assignment receipt projections #67649

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf91190
refactor(workqueue): share assignment receipt projections
pelikhan Oct 11, 2026
9cb0ff4
docs(adr): add draft ADR for work-queue receipt projections
github-actions[bot] Oct 11, 2026
ac80e6f
docs(workqueue): clarify receipt projection contracts
pelikhan Oct 11, 2026
b62bef0
Merge remote-tracking branch 'origin/main' into pelikhan-work-queue-r…
Copilot Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs(workqueue): clarify receipt projection contracts 
Explain embedded assignment projection at the CLI call site and document source claim order preservation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
  • Loading branch information
@pelikhan
pelikhan and Copilot committed Oct 11, 2026
commit ac80e6fe95215cf3583d85947001d6795743553f
1 change: 1 addition & 0 deletions pkg/cli/logs_work_queue_current.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ func currentWorkQueueAssignmentReceipt(state workqueue.Projection, assignment wo
dispatch.Run.Principal != origin.Principal {
return nil, errors.New("current snapshot origin differs from durable assignment binding")
}
// The embedded Assignment.ToReceipt projects identity; enrich lifecycle facts from the captured state.
receipt := dispatch.ToReceipt()
Comment thread
pelikhan marked this conversation as resolved.
Resolved
receipt.State, receipt.Released = dispatch.State, dispatch.Released
for i, member := range receipt.Claims {
Comment thread
pelikhan marked this conversation as resolved.
Resolved
Expand Down
5 changes: 3 additions & 2 deletions pkg/workqueue/receipts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@ type ClaimReceipt struct {
Barrier string `json:"delivery_barrier"`
}

// ToReceipt projects immutable identity only. Callers must validate the
// assignment and populate lifecycle facts from their captured projection.
// ToReceipt projects immutable identity only, preserving source claim order.
// Callers must validate the assignment and populate lifecycle facts from their
// captured projection.
func (assignment Assignment) ToReceipt() AssignmentReceipt {
receipt := AssignmentReceipt{
DispatchID: assignment.DispatchID,
Expand Down
Loading