Repository navigation
Restore safe-output server startup after memory schema change - #67506
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
October 10, 2026 20:11
View session
pelikhan
marked this pull request as ready for review
October 10, 2026 20:11
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The dependency is correctly deployed and existing tests verify transitive runtime completeness.
0 open findings
What changed in this PR
Adds the missing schema contract dependency to the isolated safe-output runtime, preventing startup failures.
Changes:
- Deploys
memory_schema_contract.cjswith its consumers.
| File | Description |
|---|---|
actions/setup/setup.sh |
Adds the required module to SAFE_OUTPUTS_FILES. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 10, 2026
1 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #67439 added a schema contract dependency but did not copy it into the isolated safe-outputs runtime. The server can therefore fail at startup with
MODULE_NOT_FOUND, even when no memory feature is used.memory_custom_validation.cjsandledger_store.cjsloadmemory_schema_contract.cjsat startup.memory_schema_contract.cjstoSAFE_OUTPUTS_FILESso it is deployed alongside its consumers.