Allow allow-listed GitHub Apps to check out same-repository PRs after comment triggers by Copilot · Pull Request #67247 · github/gh-aw

Copilot · 2026-10-09T17:17:49Z

A GitHub App listed in on.bots can activate a comment-triggered workflow, but PR checkout rejects it because Apps are not repository collaborators.

Checkout authorization: Pass on.bots to the checkout step. For issue_comment and pull_request_review_comment, bypass the collaborator check only when the allow-listed Bot authored the comment and the PR head and base repository IDs match the workflow repository.
Safety boundary: Fork PRs, unlisted bots, mismatched authors, and other actors retain the collaborator permission check. Add focused regression coverage and document the behavior.

Fixes Checkout PR branch refuses GitHub Apps listed in on.bots for comment-triggered workflows #67155

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

🟡 Changes recommended

Exact actor comparisons break the supported equivalence between App slugs and their [bot] identities.

1 open finding

Canonicalize GitHub App slug and bot identities before permission checks · New

What changed in this PR

Enables allowlisted GitHub Apps to check out same-repository PR branches after comment-triggered workflows.

Changes:

Passes on.bots into the checkout step.
Adds guarded bot authorization and regression tests.
Documents the checkout policy.

File	Description
`actions/setup/js/checkout_pr_branch.cjs`	Adds allowlisted-bot checkout authorization.
`actions/setup/js/checkout_pr_branch.test.cjs`	Tests allowed and denied scenarios.
`pkg/workflow/pr.go`	Emits the bot allowlist environment variable.
`pkg/workflow/pr_test.go`	Tests allowlist emission.
`docs/src/content/docs/reference/triggers.md`	Documents the authorization boundary.

🧠 Review effort: Balanced

Copilot · 2026-10-09T19:45:12Z

+    context.payload.sender?.login === actor &&
+    context.payload.comment?.user?.login === actor &&


Fixed in 7232560. Sender and comment-author logins must still match exactly; their identity is now compared canonically to the runtime actor using the existing slug/[bot] helper. Regression tests cover both forms for both comment events, mismatched actors, and differing sender/author login forms. All 243 checkout/permission tests pass.

gh-aw-bot · 2026-10-09T19:08:09Z

@copilot address the following outstanding work in one pass:

Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes.
Review (actions/setup/js/checkout_pr_branch.cjs:317): This exact comparison defeats the supported <slug>/<slug>[bot] equivalence when context.actor uses the plain App slug but the webhook's sender/comment logins use the bot form. check_permissions_utils.cjs:178-190 explicitly notes that GitHub Apps can appear in either form depending on event context, so an otherwise allowlisted same-repository App would still fall through to the collaborator check and be rejected. Keep sender and comment author equal to each other, then compare that identity to the runtime actor canonically. - Allow allow-listed GitHub Apps to check out same-repository PRs after comment triggers #67247 (comment)
Fix failing check Compile queue phases (FAILURE): https://github.com/github/gh-aw/actions/runs/37968089041/job/113970967002.
Fix failing check impacted-go-tests (FAILURE): https://github.com/github/gh-aw/actions/runs/37968089049/job/113971148497.
Fix failing check JS Tests (shard 4/4) (FAILURE): https://github.com/github/gh-aw/actions/runs/37968088976/job/113971150561.
Fix failing check lint-go-custom (FAILURE): https://github.com/github/gh-aw/actions/runs/37968089049/job/113971148518.
Fix failing check verify-integration-build (FAILURE): https://github.com/github/gh-aw/actions/runs/37968089049/job/113971148424.

Push the necessary fixes, reply to each listed review thread and resolve it when addressed. Ignore feedback already answered or resolved. Use the pr-finisher skill and stop when only human review or CI remains; do not trigger CI.

Sous-chef head: 2b19291
Sous-chef work: 31f7e812d45f0792093269b7b90445aa9803225a204ec130694b9ceb0227d7cc 41c633c50467b0f2dc87116833139ebf287e1ad59f1a015d8d1dfedd9d1b23f1 42e5d572d9d75b7168fe7d0aeda0717cc07e65ed240f6d299e6fec661214f1ac 57b160f058c0cf0ae8470606e768b98956d9e31df7d52cc35017efdeeaeffab1 cabafb2817b103330ac0d1e2e098f214c40c4ca2be128895a8b14391f7e3306f fa522b2e21098307804037628c5a26caf89f2fd1aad62ecb641f0ce15c8af84b
Sous-chef state: 3608c84d378f4c5e5584664987eaceeb2c1dbb7ead2bb681aadfc57134d8547c

Generated by 👨‍🍳 PR Sous Chef · pi · haiku45 · 7.09 AIC · ⌖ 7.65 AIC · ⊞ 1K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

…ranch-bot-permission-fix Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-10-09T19:45:20Z

@copilot address the following outstanding work in one pass:

Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes....

Merged main with make merge-main (9a031a3) and pushed the identity fix plus all five CI failure fixes in 7232560. Local make lint, final progress gate, full workflow/workqueue Go tests, JS shard 4 (4,240 tests), queue compilation phases, and integration build pass. Replied to the listed review thread; marking it resolved requires manual action because no thread-resolution mutation is available here. Fallback code review found no significant issues; CodeQL timed out. CI on the new HEAD remains unverified; no CI was triggered.

pelikhan · 2026-10-09T19:49:28Z

@copilot do a DevOps secops review, update compiler threat specs

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-10-09T20:04:22Z

@copilot do a DevOps secops review, update compiler threat specs

Updated the compiler threat spec/changelog and aligned RS-05a plus its unit-test/Z3 evidence. The security review found no vulnerabilities; focused tests, the final progress gate, and all modeled Z3 queries pass. Commit: dab80d3. This was a targeted RS-05a revalidation; the full architecture revalidation remains outstanding.

gh-aw-bot · 2026-10-09T20:26:52Z

@copilot address the following outstanding work in one pass:

Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes.

Push the necessary fixes, reply to each listed review thread and resolve it when addressed. Ignore feedback already answered or resolved. Use the pr-finisher skill and stop when only human review or CI remains; do not trigger CI.

Sous-chef head: dab80d3
Sous-chef work:
Sous-chef state: c40425b081548b402e6fc2c00aa9fc1767337dde07f56cd840844d9054381591

Generated by 👨‍🍳 PR Sous Chef · pi · haiku45 · 4.56 AIC · ⌖ 6.99 AIC · ⊞ 1K · ◷
_{Comment /souschef to run again}

…ranch-bot-permission-fix # Conflicts: # pkg/workflow/agy_engine_test.go # pkg/workqueue/replay.go Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-10-09T20:48:09Z

@copilot address the following outstanding work in one pass:

Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes....

Merged latest main via make merge-main, resolving the conflicts and preserving both sides’ changes. Merge commit 2de5633 is pushed; local validation passed. CI was not triggered.

gh-aw-bot · 2026-10-09T21:07:49Z

@copilot address the following outstanding work in one pass:

Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes.

Push the necessary fixes, reply to each listed review thread and resolve it when addressed. Ignore feedback already answered or resolved. Use the pr-finisher skill and stop when only human review or CI remains; do not trigger CI.

Sous-chef head: 2de5633
Sous-chef work:
Sous-chef state: b62af16ae3287e1fc805dceb9e49d14227c8d040637cab1b48f296800976e9e8

Generated by 👨‍🍳 PR Sous Chef · pi · haiku45 · 4.24 AIC · ⌖ 7.41 AIC · ⊞ 1K · ◷
_{Comment /souschef to run again}

…ranch-bot-permission-fix # Conflicts: # actions/setup/js/work_queue_issues_checks.cjs # pkg/workflow/agy_engine_test.go Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

pelikhan · 2026-10-09T21:29:44Z

@copilot resolve the merge conflicts in this pull request

Copilot · 2026-10-09T21:31:38Z

@copilot address the following outstanding work in one pass:

Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes....

Merged the latest main with make merge-main and resolved the two conflicts while preserving the branch changes. Merge commit 26b04e7 is pushed. Build, recompilation, lint, the final validation gate, and the queue integration test passed; the full JS suite has three failures in tests unchanged from main. CI was not triggered.

Copilot · 2026-10-09T21:38:36Z

@copilot resolve the merge conflicts in this pull request

The merge conflicts are resolved in merge commit 26b04e7, which is pushed. The branch is clean and has no active merge state; GitHub reports the PR as blocked while a check is still in progress.

gh-aw-bot · 2026-10-09T23:04:28Z

@copilot address the following outstanding work in one pass:

Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes.

Push the necessary fixes, reply to each listed review thread and resolve it when addressed. Ignore feedback already answered or resolved. Use the pr-finisher skill and stop when only human review or CI remains; do not trigger CI.

Sous-chef head: 26b04e7
Sous-chef work:
Sous-chef state: d501cfb6f1cc2f6d30604f2b95e1c636b94bac2307f515b4dc5090a2ecd67f0d

Generated by 👨‍🍳 PR Sous Chef · pi · haiku45 · 4.26 AIC · ⌖ 7.98 AIC · ⊞ 1K · ◷
_{Comment /souschef to run again}

…ranch-bot-permission-fix # Conflicts: # actions/setup/js/work_queue_compaction.test.cjs Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-10-09T23:24:17Z

@copilot address the following outstanding work in one pass:

Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes....

Merged latest main (3ea471b3) with make merge-main and resolved the duplicate Vitest import conflict, preserving the existing fixes. Merge commit 862d6b5e is pushed. Build, lint, workflow recompilation, final impacted-test gate, queue compilation phases, integration-tag build, and JS shard 4 (4,281 tests) pass. Fallback review found no significant issues; CodeQL timed out. CI was not triggered. The previously answered review thread remains unresolved because thread-resolution tooling is unavailable here.

pelikhan · 2026-10-10T00:17:26Z

@copilot add conformance tests, update TLA+ specs

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-10-10T00:34:18Z

@copilot add conformance tests, update TLA+ specs

Added the comment-checkout conformance matrix for both event types and the TLA+ policy model with six guard-bypass negative controls. The baseline and all negative controls passed. Commit: 9aeca60.

Initial plan

2597867

Copilot AI assigned Copilot and pelikhan Oct 9, 2026

Copilot AI linked an issue Oct 9, 2026 that may be closed by this pull request

Checkout PR branch refuses GitHub Apps listed in on.bots for comment-triggered workflows #67155

Closed

Copilot started work on behalf of pelikhan October 9, 2026 17:18 View session

Trust allow-listed bot comments for same-repository PR checkout

2b19291

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix checkout PR branch refuses GitHub Apps listed in on.bots~~ Allow allow-listed GitHub Apps to check out same-repository PRs after comment triggers Oct 9, 2026

Copilot finished work on behalf of pelikhan October 9, 2026 17:43

Copilot AI requested a review from pelikhan October 9, 2026 17:43

pelikhan marked this pull request as ready for review October 9, 2026 18:41

Copilot AI balanced review requested due to automatic review settings October 9, 2026 18:41

Copilot started reviewing on behalf of pelikhan October 9, 2026 18:41 View session

Copilot AI reviewed Oct 9, 2026

View reviewed changes

github-actions Bot mentioned this pull request Oct 9, 2026

[pr-sous-chef] PR Sous Chef 🍳 – Nudge Report #67171

Closed

Copilot started work on behalf of gh-aw-bot October 9, 2026 19:09 View session

Copilot AI and others added 3 commits October 9, 2026 19:17

Preserve compiled allowed-bot checkout configuration

44ffa9f

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into copilot/checkout-pr-b…

9a031a3

…ranch-bot-permission-fix Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Canonicalize App checkout identities and repair reported CI failures

7232560

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot October 9, 2026 19:45

Copilot AI requested a review from gh-aw-bot October 9, 2026 19:45

Copilot started work on behalf of pelikhan October 9, 2026 19:50 View session

Update compiler threat specifications for App checkout

dab80d3

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan October 9, 2026 20:04

Copilot started work on behalf of gh-aw-bot October 9, 2026 20:27 View session

Merge remote-tracking branch 'origin/main' into copilot/checkout-pr-b…

2de5633

…ranch-bot-permission-fix # Conflicts: # pkg/workflow/agy_engine_test.go # pkg/workqueue/replay.go Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot October 9, 2026 20:48

Copilot started work on behalf of gh-aw-bot October 9, 2026 21:08 View session

Merge remote-tracking branch 'origin/main' into copilot/checkout-pr-b…

26b04e7

…ranch-bot-permission-fix # Conflicts: # actions/setup/js/work_queue_issues_checks.cjs # pkg/workflow/agy_engine_test.go Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot October 9, 2026 21:32

Copilot started work on behalf of pelikhan October 9, 2026 21:33 View session

Copilot finished work on behalf of pelikhan October 9, 2026 21:39

Copilot started work on behalf of gh-aw-bot October 9, 2026 23:05 View session

Merge remote-tracking branch 'origin/main' into copilot/checkout-pr-b…

862d6b5

…ranch-bot-permission-fix # Conflicts: # actions/setup/js/work_queue_compaction.test.cjs Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot October 9, 2026 23:24

Copilot started work on behalf of pelikhan October 10, 2026 00:17 View session

Add comment checkout conformance model

9aeca60

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan October 10, 2026 00:36

pelikhan merged commit 0ad7d36 into main Oct 10, 2026
48 checks passed

pelikhan deleted the copilot/checkout-pr-branch-bot-permission-fix branch October 10, 2026 01:02

		context.payload.sender?.login === actor &&
		context.payload.comment?.user?.login === actor &&

Conversation

Copilot AI commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Copilot AI Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

gh-aw-bot commented Oct 9, 2026

Uh oh!

Copilot AI commented Oct 9, 2026

Uh oh!

pelikhan commented Oct 9, 2026

Uh oh!

Copilot AI commented Oct 9, 2026

Uh oh!

gh-aw-bot commented Oct 9, 2026

Uh oh!

Copilot AI commented Oct 9, 2026

Uh oh!

gh-aw-bot commented Oct 9, 2026

Uh oh!

pelikhan commented Oct 9, 2026

Uh oh!

Copilot AI commented Oct 9, 2026

Uh oh!

Copilot AI commented Oct 9, 2026

Uh oh!

gh-aw-bot commented Oct 9, 2026

Uh oh!

Copilot AI commented Oct 9, 2026

Uh oh!

pelikhan commented Oct 10, 2026

Uh oh!

Copilot AI commented Oct 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Oct 9, 2026 •

edited

Loading