Repository navigation
Dim slideshow toolbar when idle - #67011
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
October 8, 2026 22:38
View session
pelikhan
marked this pull request as ready for review
October 8, 2026 22:57
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
An existing test still expects the expanded drawing panel to keep the toolbar opaque, contradicting the new behavior.
1 open finding
What changed in this PR
Dims slideshow controls when idle while restoring full opacity on hover or focus.
Changes:
- Uses
:focus-withinfor toolbar focus state. - Adds idle, hover, and focus regression checks.
| File | Description |
|---|---|
docs/src/components/landing/LandingSlideshow.astro |
Updates toolbar opacity selectors. |
docs/tests/slideshow.spec.ts |
Adds toolbar-state coverage. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| await page.goto("/gh-aw/"); | ||
| }); | ||
|
|
||
| test("dims the toolbar only when neither hovered nor focused", async ({ page }) => { |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The slideshow toolbar should stay near-transparent when it is neither hovered nor focused, leaving more of the slide unobstructed.