Add privacy-preserving work queue runtime debug logging by pelikhan · Pull Request #66943 · github/gh-aw

pelikhan · 2026-10-08T16:32:34Z

Work queue failures can be difficult to diagnose when publication retries, uncertain launches, and verification recovery paths provide little diagnostic context. This adds extensive opt-in runtime logging without exposing Work payloads or credentials.

Approach

Reuse the shared JavaScript logger through a work-queue wrapper with DEBUG=work-queue:*, component selection, wildcard exclusions, and GitHub Actions runner-debug support.
Instrument scheduling, ledger replay and publication, native launch/binding, reconciliation, Claim completion and delivery verification, effects, memory preparation, and MCP intent processing.
Restrict metadata to counts, flags, retry delays, and HTTP status codes. Omit identifiers, repository names, paths, URLs, payloads, credentials, raw responses, error messages, and stack traces.
Wire the logger into deployed runtime dependencies and document namespaces and activation settings. Logging is disabled by default and preserves queue authority and publication semantics.

Validation

make fmt-cjs && make lint-cjs
npm run typecheck in actions/setup/js
make agent-report-progress
All 46 queue and deployment test suites passed with DEBUG=work-queue:* enabled: 895 tests, including privacy filtering, idempotent recovery, ambiguous-write recovery, and isolated runtime deployment checks.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-10-08T17:01:27Z

🎯 Great work on the work queue debug logging! Privacy filtering, test coverage and instrumentation look solid — this looks ready for review.

Generated by ✅ Contribution Check · copilot · auto · 47.4 AIC · ⌖ 0.609 AIC · ⊞ 9.2K · ◷

pelikhan · 2026-10-08T17:26:43Z

@copilot resolve the merge conflicts in this pull request

Copilot

🟡 Changes recommended

Error inspection in the new logger can throw and alter queue recovery behavior when debugging is enabled.

1 open finding

Guard proxy-sensitive descriptor inspection in failure diagnostics · New

What changed in this PR

Adds opt-in, privacy-preserving diagnostics across the work queue runtime.

Changes:

Adds namespace filtering and sanitized failure logging.
Instruments queue publication, scheduling, delivery, reconciliation, and MCP paths.
Deploys and documents the logger with focused tests.

File	Description
`docs/src/content/docs/reference/work-queue.md`	Documents debug activation and privacy guarantees.
`actions/setup/setup.sh`	Deploys the logger module.
`actions/setup/js/work_queue_store.cjs`	Logs storage and publication activity.
`actions/setup/js/work_queue_scheduler.cjs`	Logs scheduling decisions.
`actions/setup/js/work_queue_replay.cjs`	Logs replay and append activity.
`actions/setup/js/work_queue_reconciler.cjs`	Logs reconciliation and recovery.
`actions/setup/js/work_queue_provisioning_checks.cjs`	Validates isolated logger deployment.
`actions/setup/js/work_queue_native.cjs`	Logs native API operations.
`actions/setup/js/work_queue_memory.cjs`	Logs memory preparation.
`actions/setup/js/work_queue_mcp_server.cjs`	Logs MCP snapshot and intent activity.
`actions/setup/js/work_queue_logging.test.cjs`	Tests filtering and privacy behavior.
`actions/setup/js/work_queue_logging.cjs`	Implements the work queue logger.
`actions/setup/js/work_queue_intents.cjs`	Logs intent parsing and staging.
`actions/setup/js/work_queue_effect_client.cjs`	Logs effect mutations.
`actions/setup/js/work_queue_dispatch.cjs`	Logs dispatch and launch processing.
`actions/setup/js/work_queue_delivery.cjs`	Logs delivery verification.
`actions/setup/js/setup_sh_file_lists.test.cjs`	Checks logger deployment inclusion.
`actions/setup/js/finish_work_queue_claim.cjs`	Logs claim completion and verification.

🧠 Review effort: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Copilot · 2026-10-08T18:20:14Z

+  function failure(event, error) {
+    if (!debugEnabled(namespace)) return;
+    // Do not use debugError: API errors may contain request bodies and tokens.
+    const status = error && typeof error === "object" ? Object.getOwnPropertyDescriptor(error, "status")?.value : undefined;


Fixed in d1910f1: descriptor inspection is guarded, so throwing/revoked proxies fall back to failed=true without propagating errors or logging their contents. Added regression tests for both proxy cases and disabled-debug behavior; all 898 queue/deployment tests passed.

…ogging # Conflicts: # docs/src/content/docs/reference/work-queue.md Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-10-08T17:45:01Z

@copilot resolve the merge conflicts in this pull request

Resolved and pushed in ef2a829 by merging latest main, preserving both the workflow-example links and runtime logging documentation. All 895 queue/deployment tests passed; secret scan and merge review were clean. Final gate hit existing upstream Go lint errors; CodeQL validation was partial due to timeout.

gh-aw-bot · 2026-10-08T18:04:28Z

@copilot address the following outstanding work in one pass:

Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes.
Review (actions/setup/js/work_queue_logging.cjs:42): failure() can itself throw while handling an unknown error: Object.getOwnPropertyDescriptor invokes a proxy's getOwnPropertyDescriptor trap. With debug enabled, a proxied/revoked error therefore replaces the original queue failure and can break recovery paths that previously swallowed or classified that error. Guard descriptor inspection so diagnostics remain side-effect-free for arbitrary thrown values. - Add privacy-preserving work queue runtime debug logging #66943 (comment)

Push the necessary fixes, reply to each listed review thread and resolve it when addressed. Ignore feedback already answered or resolved. Use the pr-finisher skill and stop when only human review or CI remains; do not trigger CI.

Sous-chef head: ef2a829
Sous-chef work: 39c5c6ef71f13556dae48e266d96e53e6a48c73a41f1bd5a56a9d6eedc1983e8
Sous-chef state: 18d185c3555c0564ee2d1510cbf9ecb9cd26edc130e35adeb03624c73d6dbe6b

Generated by 👨‍🍳 PR Sous Chef · pi · haiku45 · 3.63 AIC · ⌖ 7.62 AIC · ⊞ 1K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-10-08T18:20:40Z

@copilot address the following outstanding work in one pass:

Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes....

Pushed d1910f1. make merge-main passed; latest main was already included. Guarded descriptor inspection and added throwing/revoked-proxy regression tests. Formatting, lint, typecheck, progress gate, and all 898 queue/deployment tests passed. Replied to the linked review thread, but resolution failed because gh has no token and the available MCP tools cannot resolve threads; a maintainer must mark it resolved. CI remains unverified on the new head; no CI was triggered.

github-actions · 2026-10-09T15:50:12Z

🎉 This pull request is included in a new release.

Release: v0.91.7

Add privacy-preserving work queue runtime debug logging

99004b1

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

github-actions Bot mentioned this pull request Oct 8, 2026

[Contribution Check Report] Contribution Check — 2026-10-08 #66739

Closed

pelikhan marked this pull request as ready for review October 8, 2026 17:26

Copilot AI balanced review requested due to automatic review settings October 8, 2026 17:26

Copilot started reviewing on behalf of pelikhan October 8, 2026 17:27 View session

Copilot AI reviewed Oct 8, 2026

View reviewed changes

Copilot started work on behalf of pelikhan October 8, 2026 17:33 View session

Merge remote-tracking branch 'origin/main' into pelikhan-work-queue-l…

ef2a829

…ogging # Conflicts: # docs/src/content/docs/reference/work-queue.md Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan October 8, 2026 17:45

github-actions Bot mentioned this pull request Oct 8, 2026

[pr-sous-chef] PR Sous Chef Progress: PR #66708 #66743

Closed

Copilot started work on behalf of gh-aw-bot October 8, 2026 18:04 View session

Keep work queue failure logging safe for proxied errors

d1910f1

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot October 8, 2026 18:21

Copilot AI requested a review from gh-aw-bot October 8, 2026 18:21

pelikhan assigned Copilot Oct 8, 2026

pelikhan merged commit fb759bf into main Oct 8, 2026
16 checks passed

pelikhan deleted the pelikhan-work-queue-logging branch October 8, 2026 19:19

Navigation Menu

Repository navigation

Add privacy-preserving work queue runtime debug logging - #66943

Add privacy-preserving work queue runtime debug logging#66943
pelikhan merged 3 commits into
mainfrom
pelikhan-work-queue-logging

pelikhan commented Oct 8, 2026

Uh oh!

github-actions Bot commented Oct 8, 2026

Uh oh!

pelikhan commented Oct 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 8, 2026

Uh oh!

Copilot AI commented Oct 8, 2026

Uh oh!

gh-aw-bot commented Oct 8, 2026

Uh oh!

Copilot AI commented Oct 8, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

pelikhan commented Oct 8, 2026

Approach

Validation

Uh oh!

github-actions Bot commented Oct 8, 2026

Uh oh!

pelikhan commented Oct 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Copilot AI Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Oct 8, 2026

Uh oh!

gh-aw-bot commented Oct 8, 2026

Uh oh!

Copilot AI commented Oct 8, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants