Repository navigation
Deprecate Gemini engine in favor of experimental Agy #66941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
b21198b
95a4aaf
0cca98f
e0912e8
5cec4ba
d824272
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- Loading branch information
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -82,6 +82,9 @@ func (c *Compiler) setupEngineAndImports(result *parser.FrontmatterResult, clean | |
| if err := c.runPostEngineValidations(result.Frontmatter, engineSetting, engineConfig, networkPermissions, sandboxConfig, agenticEngine, importsResult); err != nil { | ||
| return nil, err | ||
| } | ||
| if agenticEngine.GetID() == string(constants.GeminiEngine) { | ||
| fmt.Fprintln(os.Stderr, console.FormatInfoMessage("The gemini engine is deprecated in favor of the experimental agy engine. Use engine: agy where supported; retain engine: gemini for Google WIF or features Agy does not support. See https://github.github.com/gh-aw/engines/agy/")) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Switched the notice to
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [/codebase-design] This notice is printed unconditionally on every compile that resolves 💡 Suggested fixFollow the existing pattern used for other informational/warning messages in this file, e.g.: if agenticEngine.GetID() == string(constants.GeminiEngine) {
if c.batchMode {
c.featureUsage["gemini deprecation"]++
} else {
fmt.Fprintln(os.Stderr, console.FormatInfoMessageStderr("The gemini engine is deprecated..."))
}
}This keeps per-file notices during single-file compiles but avoids noisy repeated output during @copilot please address this.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Batch compilation now aggregates Gemini deprecation notices into the existing feature-usage summary, while quiet single-file compilation suppresses the notice. Added regression coverage. Fixed in e0912e8.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [/codebase-design] This uses 💡 Suggested fixfmt.Fprintln(os.Stderr, console.FormatInfoMessageStderr("The gemini engine is deprecated in favor of the experimental agy engine. ..."))Minor, but keeps the two adjacent deprecation/experimental notices in this file consistent. @copilot please address this.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Switched to the stderr-specific info formatter, preserving stderr TTY/color behavior independently of stdout. Fixed in e0912e8. |
||
| } | ||
| return &engineSetupResult{ | ||
| engineSetting: engineSetting, | ||
| model: model, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the expected option label to
Gemini (Deprecated)and covered it with the existing constants test. Fixed in e0912e8.