Repository navigation
Fix ledger append finalization and notes projections - #65928
Merged
Merged
Conversation
3 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix ledger projection and work queue smoke test failures
Fix ledger append finalization and notes projections
Oct 5, 2026
pelikhan
marked this pull request as ready for review
October 5, 2026 20:11
Contributor
There was a problem hiding this comment.
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Copilot review overview
Review effort: Lite
Findings: 1
Open (4)
elsebranch treats any non-'up'vote value as a downvote, which can silently corrupt… · New
What changed in this PR
This PR updates the notes ledger replay to materialize note_state as a physical table (instead of an SQLite view) and hardens ledger append ingestion by normalizing/removing a safe-output type discriminator before validation.
Changes:
- Replace
note_stateSQLite view generation with replay-timenote_statetable generation in the builtin notes reducer. - Simplify projection creation by removing post-processing that created the
note_stateview and metadata entry. - Normalize ledger append envelopes by stripping/validating the top-level
typefield before queueing requests; add tests for the behavior.
| File | Description |
|---|---|
| actions/setup/js/ledger_builtin.cjs | Removes NOTE_STATE_VIEW and computes/materializes note_state as a replay table. |
| actions/setup/js/create_ledger_projection.cjs | Drops special-case view creation; relies on replay output tables. |
| actions/setup/js/ledger_append.cjs | Validates append envelope shape and strips safe-output type discriminator. |
| actions/setup/js/ledger_builtin.test.cjs | Updates notes replay test to rely on table materialization (no manual view exec). |
| actions/setup/js/ledger_append.test.cjs | Adds test ensuring safe-output type is normalized before validation. |
| actions/setup/js/create_ledger_projection.test.cjs | Asserts note_state is a table and that empty projections materialize empty tables. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Reject unexpected votes during aggregation, share the empty vote-state factory, and report append envelope kinds without exposing payloads. Add regression coverage for both validation paths. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ledger smoke runs failed when safe-output validation rejected the
ledger_appendmessage envelope, preventing transaction artifacts from being written. The notes projection also exposednote_stateas a view rather than a table.typediscriminator before validating append fields, allowing the transaction artifact to be finalized and pushed.note_statewith vote totals and timestamps as a replay table, including when the ledger is empty.work_queue_readandwork_queue_claim_finish.For example, a safe-output message like
{"type":"ledger_append","ledger":"events","operation":"append","value":{}}is normalized before validation.