Skip to content

Fix IMP-004 exemption for dispatch-workflow work_queue_workflows - #65524

Merged
pelikhan merged 3 commits into
mainfrom
copilot/imp-004-add-work-queue-workflows-to-allowlist
Oct 4, 2026
Merged

Fix IMP-004 exemption for dispatch-workflow work_queue_workflows#65524
pelikhan merged 3 commits into
mainfrom
copilot/imp-004-add-work-queue-workflows-to-allowlist

Conversation

Copilot AI commented Oct 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

IMP-004 incorrectly flags dispatch-workflow.work_queue_workflows as missing from the frontmatter schema. The field is compiler-populated, not user-authored.

  • Change: Add safe-outputs.dispatch-workflow.work_queue_workflows to compiler_populated_fields, alongside workflow_files and aw_context_workflows.
  • Scope: No schema or runtime changes; no other missing compiler-populated exemptions found.

Copilot AI linked an issue Oct 4, 2026 that may be closed by this pull request
[Safe Outputs Conformance] IMP-004: dispatch-workflow work_queue_workflows missing from compiler_populated_fields allowlist #65523
Closed
@pelikhan
Fix dispatch work queue compiler-populated field conformance exemption
c75c5ba 
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Add work_queue_workflows to compiler populated fields allowlist Fix IMP-004 exemption for dispatch-workflow work_queue_workflows Oct 4, 2026
Copilot AI requested a review from pelikhan October 4, 2026 07:42
@pelikhan
pelikhan marked this pull request as ready for review October 4, 2026 07:43
Copilot AI balanced review requested due to automatic review settings October 4, 2026 07:43
Copilot AI reviewed Oct 4, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The narrow exemption matches compiler behavior and introduces no unresolved issues.

Review effort: Balanced
Findings: None

What changed in this PR

Fixes the IMP-004 false positive for a compiler-populated dispatch-workflow field, addressing #65523.

Changes:

  • Adds work_queue_workflows to the compiler-populated field exemptions.
  • Leaves schema and runtime behavior unchanged.
File Description
scripts/​check-safe-outputs-conformance.sh Exempts the internal field from schema conformance checks.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@github-actions github-actions Bot mentioned this pull request Oct 4, 2026
Closed
@gh-aw-bot

gh-aw-bot commented Oct 4, 2026

Copy link
Copy Markdown
Collaborator

@copilot address the following outstanding work in one pass:

  1. Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes.
  2. Fix failing check activation (FAILURE): https://github.com/github/gh-aw/actions/runs/37186678398/job/111390037682.
  3. Fix failing check Analyze (python) (FAILURE): https://github.com/github/gh-aw/actions/runs/37186556631/job/111389594097.
  4. Fix failing check safe_outputs (FAILURE): https://github.com/github/gh-aw/actions/runs/37186678414/job/111390705311.
  5. Fix failing check safe_outputs (FAILURE): https://github.com/github/gh-aw/actions/runs/37186678420/job/111390661731.

Push the necessary fixes, reply to each listed review thread and resolve it when addressed. Ignore feedback already answered or resolved. Use the pr-finisher skill and stop when only human review or CI remains; do not trigger CI.

Sous-chef head: c75c5ba
Sous-chef work: 43282e7f5b3023b8c8cf9099eab79e7b99f650965f08b47d3df33cde5589879d a0e3721d61627208515dab43433d4bfd19a9675eb2d47d1232914f6f7362193f c7cf93e497befdd5e698d00101b0703e4101fe4133d86d433f7c170d07402b7e
Sous-chef state: 812d53bd8f841c7d76c1858cdce5ec75277e51ce80b47638be381f8c75ed5b48

Generated by 👨‍🍳 PR Sous Chef · pi · haiku45 · 8.35 AIC · ⌖ 13.4 AIC · ⊞ 3K · ◷
Comment /souschef to run again

Merge remote-tracking branch 'origin/main' into copilot/imp-004-add-w…
16a48e7 
…ork-queue-workflows-to-allowlist

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Oct 4, 2026

Copy link
Copy Markdown
Contributor Author

@copilot address the following outstanding work in one pass:

  1. Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes....

Merged latest main with make merge-main in 16a48e7; the original exemption remains the sole PR diff. make fmt, make lint, the focused conformance test, and make agent-report-progress passed. All four CI logs show GitHub App installation API rate limits rather than code failures, so I made no unrelated workaround and did not retrigger CI. No unresolved review threads are present; this top-level PR comment is not a resolvable review thread. CI still needs a maintainer re-trigger, and the PR remains blocked pending that and human review.

Copilot AI requested a review from gh-aw-bot October 4, 2026 09:08
@github-actions github-actions Bot mentioned this pull request Oct 4, 2026
Closed
@pelikhan
pelikhan merged commit e3f660d into main Oct 4, 2026
21 checks passed
@pelikhan
pelikhan deleted the copilot/imp-004-add-work-queue-workflows-to-allowlist branch October 4, 2026 12:55
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.91.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@pelikhan pelikhan Awaiting requested review from pelikhan
@gh-aw-bot gh-aw-bot Awaiting requested review from gh-aw-bot

Assignees

@pelikhan pelikhan

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Safe Outputs Conformance] IMP-004: dispatch-workflow work_queue_workflows missing from compiler_populated_fields allowlist

4 participants

@gh-aw-bot @pelikhan