Repository navigation
Prevent stack overflow in secret-redaction file scans - #65407
Merged
Merged
Conversation
1 task
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix redact secrets in logs step failure
Prevent stack overflow in secret-redaction file scans
Oct 3, 2026
pelikhan
marked this pull request as ready for review
October 3, 2026 19:32
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The unrelated skill edit removes explicit work-queue routing and should be restored.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Prevents stack overflow during large secret-redaction scans by using iterative file traversal.
Changes:
- Replaces recursive traversal and spread appends with an explicit stack.
- Adds regression coverage for 150,000 files.
- Reorders a workflow-skill entry but inadvertently removes its routing instruction.
| File | Description |
|---|---|
actions/setup/js/redact_secrets.cjs |
Implements iterative scanning while retaining symlink removal. |
actions/setup/js/redact_secrets.test.cjs |
Tests large nested file discovery. |
.github/skills/agentic-workflows/SKILL.md |
Moves the work-queue entry but removes explicit routing. |
| @@ -106,7 +106,6 @@ After loading the matching workflow prompt or skill, follow it directly: | |||
| - Render compact markdown charts: `.github/aw/asciicharts.md` | |||
| - Map CLI commands to MCP usage: `.github/aw/cli-commands.md` | |||
| - Choose workflow architecture and patterns: `.github/aw/patterns.md` | |||
Collaborator
|
@copilot resolve the merge conflicts on this branch. |
…crets-in-logs-step-failure # Conflicts: # actions/setup/js/redact_secrets.cjs Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Resolved the conflict and merged |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The “Redact secrets in logs” step can fail after the agent succeeds when a large artifact directory overflows the scanner’s call stack. This affects multiple workflows that share the redaction step.