Repository navigation
[eslint-miner] eslint-factory: add no-unhandled-async-timer-callback rule - #65292
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New rule:
no-unhandled-async-timer-callbackFlags
awaitoutside a try/catch inside asyncsetTimeout/setInterval/setImmediatecallbacks (includingglobalThis./global.forms). Timers discard the returned promise, so a rejection becomes an unhandled rejection that can crash the Node process.Evidence
actions/setup/js/process_runner.cjs(~L430) usessetInterval(async () => ...)with theawaitcorrectly wrapped in try/catch/finally. The rule enforces that pattern for future timer callbacks.actions/setup/jsare synchronous, so there are no false positives today (npm run lint:setup-jsreports 0 hits).no-async-foreach-callback(same discarded-promise class of bug).Design
Only async function callbacks passed directly as the first timer argument; awaits in nested functions are not attributed to the timer callback; awaits in
catch/finallyare still reported.Validation
npm install,npm run build, rule unit tests, andnpm run lint:setup-jsall pass. Registered insrc/index.ts, enabled aswarnineslint.config.cjs.