feat: report dispatch coordinator operations in logs and audit by pelikhan · Pull Request #65163 · github/gh-aw

pelikhan · 2026-10-03T00:37:22Z

Why

Dispatcher work coordinator evidence is spread across activation snapshots, agent finish-intent files, and workflow job logs. gh aw logs and gh aw audit need to collect and expose that evidence so queue publication and worker reconciliation can be investigated from a single report.

Approach

Add the dispatch-coordinator artifact set to download activation and agent artifacts plus workflow logs, including missing diagnostic logs for previously cached runs.
Extract queue snapshot transactions, worker assignments, finish intents, and timestamped coordinator operations into dispatch_coordinator in JSON and text reports.
Deduplicate whole-job/per-step log copies, retain source-file provenance, and backfill partial cached reports. Bump the audit cache schema to regenerate older reports.
Validate malformed coordinator data and document the artifact selection and report fields.

Activation transactions are historical queue facts, not operations performed by the audited run. A finish intent is an agent request, not a verified completion; publication and reconciliation diagnostics are reported separately. The compact logs default remains unchanged, while default audit downloads include this evidence.

Usage

gh aw logs <run-id> --artifacts dispatch-coordinator --json
gh aw audit <run-id> --artifacts dispatch-coordinator --json

Validation

Passed:

make build and make fmt
go test ./pkg/cli -run 'Test(DispatchCoordinator|DownloadDispatchCoordinator|DownloadRunArtifacts|CollectAuditAnalysisResults|AuditUsesRunSummaryCache|CachedAudit|LoadCachedAuditData|WriteLogsAuditFiles|RenderLogsCompact|LogsCompact)' -count=1
go test -race ./pkg/cli -run 'Test(DispatchCoordinator|CollectAuditAnalysisResults)' -count=1
golangci-lint run --allow-parallel-runners ./pkg/cli
git diff --check

make agent-report-progress ran, including impacted unit tests. The full gate remains blocked by pre-existing custom-linter findings in touched files, including oversized existing functions, slice-index diagnostics, and an explicitly discarded Close() error. New coordinator-specific lint findings were corrected. A subsequent standard Go lint run passed with zero issues.

Download coordinator snapshots, finish intents, and workflow diagnostics with the dispatch-coordinator artifact set. Extract timestamped operations into text and JSON reports and preserve evidence across cached reports. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

pelikhan · 2026-10-03T00:43:14Z

@copilot call it work-queue

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-10-03T00:57:59Z

@copilot call it work-queue

Renamed the artifact selector and report fields to work-queue / work_queue in commit 6b06fae.

github-actions · 2026-10-03T00:59:42Z

✅ Ponytail Reviewer completed successfully!

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Generated by Ponytail Reviewer for #65163

github-actions · 2026-10-03T00:59:45Z

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch test file diff

🧪 Test quality analysis by Test Quality Sentinel

github-actions · 2026-10-03T00:59:50Z

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

🏗️ ADR gate enforced by Design Decision Gate 🏗️

github-actions · 2026-10-03T01:00:01Z

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

github-actions · 2026-10-03T01:00:03Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

github-actions · 2026-10-03T01:05:06Z

🏗️ ADR required — draft added

A draft ADR has been added at docs/adr/65163-report-dispatch-coordinator-operations-in-audit-and-logs.md.

Why this PR is gated

ADR enforcement applies because this PR adds more than 100 new lines in business-logic directories (pkg/ additions: 867 lines).
No ADR reference was found in the PR body.
The existing dispatch-coordinator ADRs (docs/adr/64955-git-backed-dispatch-work-coordination.md and docs/adr/dispatch-work-coordinator-protocol-upgrades.md) cover queue coordination and protocol upgrades, but not this new reporting decision.

Evidence used

PR title/body: reporting dispatch coordinator operations in gh aw logs and gh aw audit
Diff: new DispatchCoordinatorReport / work_queue output, new work-queue artifact set, cache-schema bumps, and backfill logic for cached reports

Next action

Review and refine the draft ADR, especially the decision scope and trade-offs, then keep it with this PR as the explicit design record for the reporting change.

🏗️ ADR gate enforced by Design Decision Gate 🏗️ · pi · gpt54 · 22.8 AIC · ⌖ 10.9 AIC · ⊞ 10.4K · ◷
_{Comment /review to run again}

Copilot

Copilot review overview

🟡 Changes recommended

Coordinator evidence can be spoofed, malformed snapshots accepted, and cache/download state misidentified.

Review effort: Balanced
Findings: 5

Open (5)

Reject snapshots with omitted required fields · New
Restrict coordinator message extraction to trusted log paths · New
Preserve artifact selection when detecting coordinator requests · New
Use atomic completion tracking for workflow log extraction · New
Escape control characters in work and claim IDs · New

What changed in this PR

Adds dispatch coordinator evidence to logs and audit reports.

Changes:

Adds work-queue artifact collection, extraction, caching, and rendering.
Extends JSON schemas and cache versions.
Adds tests and documentation.

File	Description
`schemas/logs.schema.json`	Adds work-queue schema.
`schemas/logs-jsonl.schema.json`	Adds work-queue fields and v3.
`schemas/audit.schema.json`	Adds audit work-queue schema.
`pkg/cli/mcp_tools_privileged.go`	Exposes the artifact set through MCP.
`pkg/cli/logs_run_processor.go`	Backfills and persists coordinator evidence.
`pkg/cli/logs_report.go`	Adds coordinator data and rendering.
`pkg/cli/logs_orchestrator_filters.go`	Propagates coordinator reports.
`pkg/cli/logs_models.go`	Adds coordinator report fields.
`pkg/cli/logs_format_compact.go`	Renders compact work-queue output.
`pkg/cli/logs_download.go`	Downloads diagnostic workflow logs.
`pkg/cli/logs_dispatch_coordinator.go`	Extracts and validates evidence.
`pkg/cli/logs_dispatch_coordinator_test.go`	Tests extraction and propagation.
`pkg/cli/logs_dispatch_coordinator_render.go`	Renders coordinator reports.
`pkg/cli/logs_cached_json.go`	Caches coordinator data in JSONL.
`pkg/cli/logs_cached_json_test.go`	Updates cache-version tests.
`pkg/cli/logs_artifact_set.go`	Defines `work-queue`.
`pkg/cli/logs_artifact_set_test.go`	Tests artifact-set registration.
`pkg/cli/audit.go`	Adds coordinator analysis results.
`pkg/cli/audit_summary_build.go`	Propagates results into summaries.
`pkg/cli/audit_run_pipeline.go`	Backfills cached audits.
`pkg/cli/audit_report.go`	Adds structured audit output.
`pkg/cli/audit_report_render.go`	Renders audit work-queue sections.
`pkg/cli/audit_render_output.go`	Merges cached coordinator reports.
`pkg/cli/audit_cache.go`	Updates audit cache handling.
`pkg/cli/audit_analysis_fanout.go`	Runs coordinator extraction.
`docs/src/content/docs/setup/cli.md`	Documents artifact selection.
`docs/src/content/docs/reference/audit.md`	Documents report fields and usage.

github-actions

Request changes

The new work-queue reporting has two blocking cache-path regressions: the default cached audit path can still skip backfilling coordinator evidence entirely, and the compact logs path now leaks cached coordinator data into usage-only runs.

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt54 · 69.2 AIC · ⌖ 6.96 AIC · ⊞ 20.2K
_{Comment /review to run again}

github-actions

Skills-Based Review 🧠

Applied /tdd and /codebase-design on the new logs_dispatch_coordinator*.go module and its wiring into audit/logs. Requesting changes on one correctness/security concern in the operation-extraction trust model; everything else is solid.

📋 Key Themes & Highlights

Key Themes

Trust boundary on log-derived evidence: extractDispatchCoordinatorOperations accepts any job-log line matching a timestamp + known-prefix pattern as genuine coordinator evidence, with no restriction to a specific step/job source. Since this report is meant to be authoritative audit evidence ("operations observed... not operations performed by the audited run" per the PR description), a forged line with a real-looking timestamp from attacker-influenced job output could be indistinguishable from genuine coordinator output.
Flag coupling: renderAuditReport's new coordinator-report backfill write is silently gated by opts.NoBaseline, an unrelated flag, without explaining the relationship.
Test coverage: the existing forged fixture only demonstrates the (less interesting) timestamp-missing rejection path, not the actual risk of a well-formed forged timestamp.

Positive Highlights

✅ Careful separation of activation-time queue facts (snapshot/transactions), agent intent (finish_intent), and runtime observations (operations) — a clear, well-documented domain model.
✅ Strong validation of snapshot/transaction/finish-intent shapes (parseDispatchCoordinatorTransaction, parseDispatchCoordinatorSnapshot) with comprehensive table-driven tests.
✅ Thoughtful backfill/merge/dedup handling across cache schema bumps (backfillDispatchCoordinatorReport, mergeDispatchCoordinatorReport), with an end-to-end propagation test (TestDispatchCoordinatorReportPropagation) covering the whole pipeline.
✅ Schema, docs, and CLI help text updated consistently alongside the new work-queue artifact set.

Findings are flagged inline. Fallback note: pr-triage ran successfully, so no fallback heuristic was needed.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet50 · 148.1 AIC · ⌖ 14.7 AIC · ⊞ 10K
_{Comment /matt to run again}

Require nullable snapshot properties, accept operations only from coordinator-owned step logs, and escape control characters in text reports. Preserve explicit work-queue selection, backfill default audit downloads, and atomically publish completed workflow log archives. Refresh cache schema versions and regression fixtures without exposing cached work queue evidence in usage-only logs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

gh-aw-bot · 2026-10-03T01:40:36Z

@copilot Please review this PR for forward progress: check unresolved review feedback, failed checks, and whether the branch needs a refresh. If action is needed, please continue with the pr-finisher skill.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 11.4 AIC · ⌖ 8.58 AIC · ⊞ 9.4K · ◷
_{Comment /souschef to run again}

…perations-reports Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-10-03T02:01:51Z

@copilot Please review this PR for forward progress: check unresolved review feedback, failed checks, and whether the branch needs a refresh. If action is needed, please continue with the pr-finisher ...

Refreshed the branch from main (now at 250e582) and pushed merge commit 5fea602, plus a NoBaseline cache-backfill clarification in 493525d. The open findings are fixed or clarified and replies have been posted. make fmt, make lint, make test, and make recompile passed; the final make agent-report-progress check still reports the pre-existing custom Go linter findings in touched files. The previous PR checks had no failures, but this push has no CI checks yet. CodeQL validation timed out; the available validation tool says not to rerun it.

Done

github-actions · 2026-10-05T23:11:09Z

🎉 This pull request is included in a new release.

Release: v0.91.0

Copilot started work on behalf of pelikhan October 3, 2026 00:44 View session

Copilot AI and others added 2 commits October 3, 2026 00:52

Update generated coordinator report schemas

9ae1576

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Rename coordinator reporting to work queue

6b06fae

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan October 3, 2026 00:58

pelikhan marked this pull request as ready for review October 3, 2026 00:58

Copilot AI balanced review requested due to automatic review settings October 3, 2026 00:58

Copilot started reviewing on behalf of pelikhan October 3, 2026 00:59 View session

github-actions Bot mentioned this pull request Oct 3, 2026

[aw] Ponytail Reviewer produced no safe outputs #65072

Closed

github-actions Bot added the needs-review label Oct 3, 2026

docs: add ADR for dispatch coordinator reporting

5a598b7

Copilot AI reviewed Oct 3, 2026

View reviewed changes

github-actions Bot previously requested changes Oct 3, 2026

View reviewed changes

Comment thread pkg/cli/audit_run_pipeline.go Outdated

Comment thread pkg/cli/logs_format_compact.go

github-actions Bot reviewed Oct 3, 2026

View reviewed changes

Comment thread pkg/cli/logs_dispatch_coordinator.go Outdated

Comment thread pkg/cli/audit_render_output.go

Comment thread pkg/cli/logs_dispatch_coordinator_test.go

github-actions Bot mentioned this pull request Oct 3, 2026

[aw] Impeccable Skills Reviewer timed out #65196

Closed

github-actions Bot mentioned this pull request Oct 3, 2026

[pr-sous-chef] PR Sous Chef run report #65135

Closed

Copilot started work on behalf of gh-aw-bot October 3, 2026 01:41 View session

Copilot AI and others added 2 commits October 3, 2026 01:47

Merge remote-tracking branch 'origin/main' into pelikhan-dispatcher-o…

5fea602

…perations-reports Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Clarify NoBaseline work-queue cache behavior

493525d

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot October 3, 2026 02:03

Copilot AI requested a review from gh-aw-bot October 3, 2026 02:03

pelikhan merged commit 4f7ee4b into main Oct 3, 2026
21 checks passed

pelikhan deleted the pelikhan-dispatcher-operations-reports branch October 3, 2026 02:21

Conversation

pelikhan commented Oct 3, 2026

Why

Approach

Usage

Validation

Uh oh!

pelikhan commented Oct 3, 2026

Uh oh!

Copilot AI commented Oct 3, 2026

Uh oh!

github-actions Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Request changes

Uh oh!

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Key Themes

Positive Highlights

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gh-aw-bot commented Oct 3, 2026

Uh oh!

Copilot AI commented Oct 3, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Oct 3, 2026 •

edited

Loading

github-actions Bot commented Oct 3, 2026 •

edited

Loading

github-actions Bot commented Oct 3, 2026 •

edited

Loading

github-actions Bot commented Oct 3, 2026 •

edited

Loading

github-actions Bot commented Oct 3, 2026 •

edited

Loading