Skip to content

Allow engine.model to override top-level model per engine instance #54366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 13 commits into from
Aug 21, 2026
Merged

Allow engine.model to override top-level model per engine instance #54366

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
09c354f
Initial plan
Copilot Aug 20, 2026
4dc17d0
Allow engine.model as a per-instance override, remove deprecation and…
Copilot Aug 20, 2026
d7e4e5c
Fix missing newline in regenerated frontmatter doc
Copilot Aug 20, 2026
661811e
Provide actionable engine JSON parse error
Copilot Aug 20, 2026
5cfdb11
Merge branch 'main' into copilot/fix-engine-model-deprecation
Copilot Aug 21, 2026
6266e5a
Merge branch 'main' into copilot/fix-engine-model-deprecation
github-actions[bot] Aug 21, 2026
e590bc5
Plan address outstanding review feedback
Copilot Aug 21, 2026
ac48331
Address engine model precedence review feedback
Copilot Aug 21, 2026
7602050
Assert split engine models in compiled output
Copilot Aug 21, 2026
5623b17
Parse split engine lock metadata in test
Copilot Aug 21, 2026
15eb0bf
Clarify split engine lock metadata assertions
Copilot Aug 21, 2026
501050d
Clarify default model guidance
Copilot Aug 21, 2026
b03a9c7
Merge branch 'main' into copilot/fix-engine-model-deprecation
pelikhan Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Plan address outstanding review feedback 
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
  • Loading branch information
@gh-aw-bot
Copilot and gh-aw-bot authored Aug 21, 2026
commit e590bc59ba205916240c1004267363e263d3f457
4 changes: 0 additions & 4 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
charm.land/bubbles/v2 v2.1.1 h1:7r55WzBxpo/R3z98hGmY7KKPd3ET6vsf0Fb9sDHOV60=
charm.land/bubbles/v2 v2.1.1/go.mod h1:GE6M31gaWZVXzGw73OeuTTgy4lX+OtkH0E5ymnNsHxo=
charm.land/bubbles/v2 v2.2.0 h1:9GEMewcejrNtVIxZ9Y2wSsWJamsWNsXa8MpMLnH4yI4=
charm.land/bubbles/v2 v2.2.0/go.mod h1:wdMgn+sje1KNXdwFizIWjbf328fIUBxqEmJ/vYPo8yc=
charm.land/bubbletea/v2 v2.0.8 h1:SxTJMhCAI3lbPmy4SgX5LWZ24AdINr4I6UEqzZvYJuY=
Expand Down Expand Up @@ -144,8 +142,6 @@ github.com/mattn/go-colorable v0.1.14 h1:9A9LHSqF/7dyVVX6g0U9cwm9pG3kP9gSzcuIPHP
github.com/mattn/go-colorable v0.1.14/go.mod h1:6LmQG8QLFO4G5z1gPvYEzlUgJ2wF+stgPZH1UqBm1s8=
github.com/mattn/go-isatty v0.0.20 h1:xfD0iDuEKnDkl03q4limB+vH+GxLEtL/jb4xVJSWWEY=
github.com/mattn/go-isatty v0.0.20/go.mod h1:W+V8PltTTMOvKvAeJH7IuucS94S2C6jfK/D7dTCTo3Y=
github.com/mattn/go-runewidth v0.0.24 h1:cpokDiIn0MGnhdHwuWnJBITySJ20QyNGnY2kR/ay2DU=
github.com/mattn/go-runewidth v0.0.24/go.mod h1:XBkDxAl56ILZc9knddidhrOlY5R/pDhgLpndooCuJAs=
github.com/mattn/go-runewidth v0.0.27 h1:Feg/Oou5zI/wnpgDF6omIU0OokC9GxLC/WRknhVlIR0=
github.com/mattn/go-runewidth v0.0.27/go.mod h1:3qAiGCV4Koz/yuveO58qUefmUTRm8r0IGEXZ9jeHp/8=
github.com/mattn/go-shellwords v1.0.12 h1:M2zGm7EW6UQJvDeQxo4T51eKPurbeFbe8WtebGE2xrk=
Expand Down