Skip to content

Refactor shared value formatting and unify GitHub error/SHA classification paths #53018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 8 commits into from
Aug 16, 2026
Merged

Refactor shared value formatting and unify GitHub error/SHA classification paths #53018

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3bb758b
Initial plan
Copilot Aug 16, 2026
d07bf7c
Refactor shared formatters and error classifiers
Copilot Aug 16, 2026
3ef7e0d
Address review feedback on classifier and env formatting refactor
Copilot Aug 16, 2026
a0856f2
docs(adr): add draft ADR-53018 for error classifier centralization
github-actions[bot] Aug 16, 2026
49a8e93
Merge branch 'main' into copilot/refactor-duplicate-value-formatting-…
github-actions[bot] Aug 16, 2026
aaec1b1
Address SHA and auth classifier review feedback
Copilot Aug 16, 2026
7935c8f
Merge branch 'main' into copilot/refactor-duplicate-value-formatting-…
github-actions[bot] Aug 16, 2026
6f6c0ec
Clarify rate limit classifier documentation
Copilot Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clarify rate limit classifier documentation 
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
  • Loading branch information
@gh-aw-bot
Copilot and gh-aw-bot authored Aug 16, 2026
commit 6f6c0ec287f7adf0c060b6f82ff821a56efc42ef
2 changes: 1 addition & 1 deletion pkg/errorutil/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ This package currently exposes focused helpers for identifying common error cate
| `IsNotFoundError` | `func(err error) bool` | Returns `true` when `err` indicates a "not found" condition by matching case-insensitive `404` or `not found` text; returns `false` for `nil` and non-matching errors |
| `IsForbiddenError` | `func(err error) bool` | Returns `true` when `err` indicates an HTTP-style `403`/"forbidden" response by matching case-insensitive patterns like `HTTP 403` or `403 Forbidden`; returns `false` for `nil` and non-matching errors |
| `IsGoneError` | `func(err error) bool` | Returns `true` when `err` indicates an HTTP-style `410`/"gone" response by matching case-insensitive patterns like `HTTP 410` or `410 Gone`; returns `false` for `nil` and non-matching errors |
| `IsRateLimitError` | `func(output string) bool` | Returns `true` when `output` indicates GitHub API rate limiting by matching case-insensitive `rate limit exceeded` or `secondary rate limit` text |
| `IsRateLimitError` | `func(output string) bool` | Returns `true` when `output` indicates GitHub API rate limiting by matching case-insensitive `rate limit exceeded` (including `API rate limit exceeded`) or `secondary rate limit` text |
| `IsAuthError` | `func(output string) bool` | Returns `true` when `output` indicates authentication or authorization failures by matching case-insensitive credential-specific markers including `GH_TOKEN`, `GITHUB_TOKEN`, `authentication`, `not logged into`, `unauthorized`, `permission denied`, or `SAML enforcement` |

## Usage Examples
Expand Down
Loading