Skip to content

[purelock] Lock down firstForbiddenCharInParamValue, validateGCPWIFEngineAuth, hasPullRequestTargetTrigger with pure-function test suites #52890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Aug 15, 2026
Merged

[purelock] Lock down firstForbiddenCharInParamValue, validateGCPWIFEngineAuth, hasPullRequestTargetTrigger with pure-function test suites #52890

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60ea272
test: add pure-function test suites for 3 low-coverage functions
github-actions[bot] Aug 15, 2026
a23c80a
test: remove redundant loop variable copies
Copilot Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: remove redundant loop variable copies 
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
  • Loading branch information
@pelikhan
Copilot and pelikhan authored Aug 15, 2026
commit a23c80a36b53e3e37b0ebd86391ebe6680cd6651
1 change: 0 additions & 1 deletion pkg/cli/codemod_pull_request_target_trigger_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ func TestHasPullRequestTargetTrigger(t *testing.T) {
}

for _, tt := range tests {
tt := tt
t.Run(tt.name, func(t *testing.T) {
t.Parallel()
got := hasPullRequestTargetTrigger(tt.frontmatter)
Expand Down
1 change: 0 additions & 1 deletion pkg/workflow/compiler_validators_gcp_wif_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ func TestValidateGCPWIFEngineAuth(t *testing.T) {
}

for _, tt := range tests {
tt := tt
t.Run(tt.name, func(t *testing.T) {
t.Parallel()
err := validateGCPWIFEngineAuth(tt.workflow)
Expand Down
1 change: 0 additions & 1 deletion pkg/workflow/model_identifier_param_value_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ func TestFirstForbiddenCharInParamValue(t *testing.T) {
}

for _, tt := range tests {
tt := tt
t.Run(tt.name, func(t *testing.T) {
t.Parallel()
got := firstForbiddenCharInParamValue(tt.in)
Expand Down
Loading