Skip to content

Keep safe-output token placeholders out of runtime config.json #36353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 12 commits into from
Jun 2, 2026
Merged

Keep safe-output token placeholders out of runtime config.json #36353

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b2d44cb
Initial plan
Copilot Jun 1, 2026
1131de2
fix: keep safe-output config placeholders off disk
Copilot Jun 1, 2026
5bbf951
test: tighten safe-output placeholder coverage
Copilot Jun 1, 2026
a348be5
test: relax safe-output env count assertions
Copilot Jun 1, 2026
cc4ef74
Merge branch 'main' into copilot/fix-secrets-exposure-issue
pelikhan Jun 1, 2026
f0cc4b3
docs: add draft ADR for safe-output secret placeholder handling
github-actions[bot] Jun 1, 2026
c26d768
chore: plan for addressing PR review feedback
Copilot Jun 1, 2026
608e4aa
fix: namespace secret env vars and extract shared redact helper
Copilot Jun 1, 2026
bf80cee
docs: improve inline documentation for secret env prefix and redact h…
Copilot Jun 1, 2026
ea9db61
fix: add safe_outputs_config_redact.cjs to deployment list
Copilot Jun 1, 2026
e301e41
fix: add safe_outputs_config_redact.cjs to deployment and required de…
Copilot Jun 1, 2026
fc95bbe
style: fix Prettier formatting in safe_outputs_config_redact.cjs and …
Copilot Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
style: fix Prettier formatting in safe_outputs_config_redact.cjs and … 
…safe_outputs_config.test.cjs

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
  • Loading branch information
@pelikhan
Copilot and pelikhan authored Jun 2, 2026
commit fc95bbee2df24d98c4f938b977a6073179e1e122
2 changes: 1 addition & 1 deletion actions/setup/js/safe_outputs_config.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ describe("safe_outputs_config", () => {
"github-token": "${WRITE_PROJECT_PAT}",
"target-repo": "${GH_AW_INPUT_TARGET_REPO}",
},
}),
})
);

/** @type {import("./safe_outputs_config.cjs").LoadConfigResult} */
Expand Down
7 changes: 1 addition & 6 deletions actions/setup/js/safe_outputs_config_redact.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,7 @@ function redactSensitiveConfig(value) {
return value.map(redactSensitiveConfig);
}
if (value && typeof value === "object") {
return Object.fromEntries(
Object.entries(/** @type {Record<string, unknown>} */ (value)).map(([key, nestedValue]) => [
key,
isSensitiveConfigKey(key) ? "***REDACTED***" : redactSensitiveConfig(nestedValue),
]),
);
return Object.fromEntries(Object.entries(/** @type {Record<string, unknown>} */ value).map(([key, nestedValue]) => [key, isSensitiveConfigKey(key) ? "***REDACTED***" : redactSensitiveConfig(nestedValue)]));
}
return value;
}
Expand Down
Loading