You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PR is very large: it changes hundreds of files, and the file patches total about 690 KB. Most are regenerated .lock.yml files, plus docs and workflow .md files.
Only file names and a few patches were inspected. I could not run the line-level checks on it: missing error handling, exported functions without doc comments, assertion-free tests and functions over 80 lines.
Neither the Go sources nor .github/scripts/work-queue-formal-check.test.cjs was inspected.
The PR carries a major changeset (breaking change). Consider splitting it into smaller reviewable PRs.
#56568 — Unsigned push fallback in pushSignedCommits
The change is in actions/setup/js/push_signed_commits.cjs, which is JavaScript, so the Go-specific checks do not apply. The diff was only partly read, and the tests were not checked.
Error handling is improved. A failed git rebase --abort is now fatal instead of silently ignored, and the error carries a cause.
It adds a new error class, PushSignedCommitsUnsignedFallbackFailed, with a doc comment.
The fallback runs the same merge-commit, file-mode and file-protection validation as the other unsigned-push paths.
The pushSignedCommits function is already very long, and this PR adds roughly 100 more lines to it. That is well over the 80-line guideline, so consider extracting the rebase-recovery and fallback logic into helpers.
I did not check whether tests for the new fallback paths were added.
Activity
github-actions commentedon Oct 9, 2026
This issue was automatically closed because it expired on 2026-10-09T05:55:58.134Z.