[lint-monster] LintMonster: handle ignored results and related Go idioms (1,149 findings) #66760

Daily custom lint findings

The 2026-10-08 make golint-custom pre-check reported 1,149 findings in this combined reliability and idiom group:

• 903 unchecked fmt.Fprint* write results across console and other packages.
• 9 scanner loops that do not check Err() after iteration.
• 6 explicitly discarded Close() errors.
• 161 ignored assertion or assignment results.
• 70 related Go idiom findings, including builder reuse without Reset, manual path concatenation, reflect.DeepEqual conditionals, mutable package-level state, and map-as-set allocations.

Most findings are in pkg/workflow (652), pkg/cli (342), and pkg/console (49), with additional parser and utility findings.

Remediation checklist

• Check each ignored result and handle it using the narrowest error path that fits the surrounding function; retain meaningful output/error behavior.
• Check Scanner.Err() after each scan loop and handle close failures where the caller can act on them.
• For the related idiom findings, make small targeted fixes at flagged sites, resetting builders between independent writes and using the appropriate path helper without changing URL semantics.
• Keep edits scoped to this group and avoid analyzer suppressions.
• Run make golint-custom and confirm this group is cleared.

Source: lint run §37719656581.

Generated by 🧌 LintMonster · codex · gpt60 · 175.2 AIC · ⌖ 28.6 AIC · ⊞ 15.5K · ◷

• expires on Oct 14, 2026, 6:56 PM UTC-08:00