Mark the example server package as private - #4
Merged
Merged
Conversation
Nothing in this repository is published to a package registry, and the name external-custom-properties-example-server is unclaimed on npm. Without the private flag, npm publish from example-server would succeed, so a contributor running it by mistake could put a GitHub-authored package on the registry. Setting private makes npm refuse. Install, test, lint, and run are unaffected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 97372c67-02e2-4b8b-a713-1d9e9c42f6ca
darthwillis
requested review from
isaacmbrown and
joshbanks14
and
a balanced review from Copilot
September 30, 2026 18:20
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused manifest change correctly prevents accidental publication without affecting runtime behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Marks the example server package as non-publishable to prevent accidental npm publication.
Changes:
- Adds
"private": trueto the package manifest.
| File | Description |
|---|---|
example-server/package.json |
Prevents publishing the example server package. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
joshbanks14
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
"private": truetoexample-server/package.json.Why
Nothing in this repository is published to a package registry — without the private flag
npm publishfromexample-server/would succeed.Scope
One line.
npm install,npm test,npm run lint, andnpm run serverare unaffected — the flag only gates publishing.