Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
d430deb
Update changelog and version after v1.1.4
invalid-email-address Mar 7, 2022
0e0e934
1.1.5
invalid-email-address Mar 7, 2022
c825c24
Update checked-in dependencies
invalid-email-address Mar 7, 2022
d2fd19b
Merge pull request #966 from github/mergeback/v1.1.4-to-main-f5d82270
aeisenberg Mar 8, 2022
111428c
Add some instructions on how to regenerate required checks
aeisenberg Mar 8, 2022
628afae
Add a timeout of 30 min
aeisenberg Mar 8, 2022
cdf3c9d
Merge pull request #971 from github/aeisenberg/timeouts
aeisenberg Mar 9, 2022
04d521d
Avoid using `sed`, use `--slurp` instead
aeisenberg Mar 9, 2022
4e2634f
Merge branch 'main' into aeisenberg/required-checks
aeisenberg Mar 10, 2022
480ef76
Update default CodeQL bundle version to 2.8.3
aibaars Mar 11, 2022
0b3acf6
Bump ML-powered queries to v0.1.0
henrymercer Mar 11, 2022
8ecc1fc
Ignore "Update Supported Enterprise Server Versions"
aeisenberg Mar 11, 2022
e437ea1
Merge pull request #975 from github/henrymercer/bump-ml-powered-queri…
henrymercer Mar 11, 2022
e64a215
Add name to workflow
aeisenberg Mar 11, 2022
560edbc
Merge branch 'main' into aeisenberg/required-checks
henrymercer Mar 11, 2022
761da7e
Merge pull request #968 from github/aeisenberg/required-checks
aeisenberg Mar 11, 2022
aeefdce
Restore compatibility with GHES 3.1
cklin Mar 14, 2022
c33cdd7
Merge branch 'main' into cklin/pr/2.8.3
cklin Mar 14, 2022
eb507cf
Remove runner from expected release files
edoardopirovano Mar 14, 2022
e27fa67
Add changenote mentioning deprecation
edoardopirovano Mar 14, 2022
b74506c
Merge pull request #974 from github/cklin/pr/2.8.3
cklin Mar 14, 2022
e61a4b9
Merge branch 'main' into edoardo/release-expected
edoardopirovano Mar 14, 2022
2190825
Merge pull request #980 from github/edoardo/release-expected
cklin Mar 14, 2022
39aa619
Merge branch 'main' into restore-ghes-compatibility
cklin Mar 14, 2022
ea5898d
Restore compatibility with GHES 3.1: address code review comments
cklin Mar 14, 2022
5b59d87
Merge pull request #978 from cklin/restore-ghes-compatibility
cklin Mar 15, 2022
69a58ad
1.1.5
invalid-email-address Mar 15, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add some instructions on how to regenerate required checks
  • Loading branch information
aeisenberg committed Mar 8, 2022
commit 111428ce06b1d04488cf2bb08b39bc6ac3c85a55
22 changes: 21 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ Here are a few things you can do that will increase the likelihood of your pull
1. The first step of releasing a new version of the `codeql-action` is running the "Update release branch" workflow.
This workflow goes through the pull requests that have been merged to `main` since the last release, creates a changelog, then opens a pull request to merge the changes since the last release into the `v1` release branch.

A release is automatically started every Monday via a scheduled run of this workflow, however you can start a release manually by triggering a run via [workflow dispatch](https://github.com/github/codeql-action/actions/workflows/update-release-branch.yml).
A release is automatically started every Monday via a scheduled run of this workflow, however you can start a release manually by triggering a run via [workflow dispatch](https://github.com/github/codeql-action/actions/workflows/update-release-branch.yml).
1. The workflow run will open a pull request titled "Merge main into v1". Mark the pull request as [ready for review](https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#marking-a-pull-request-as-ready-for-review) to trigger the PR checks.
1. Review the checklist items in the pull request description.
Once you've checked off all but the last of these, approve the PR and automerge it.
Expand All @@ -72,6 +72,26 @@ Here are a few things you can do that will increase the likelihood of your pull

Approve the mergeback PR and automerge it. Once the mergeback has been merged into main, the release is complete.

## Keeping the PR checks up to date (requires admin access)

Since the `codeql-action` runs most of its testing through individual Actions workflows, there are over two hundred jobs that need to pass in order for a PR to turn green. Managing these PR checks manually is time consuming and complex. Here is a semi-automated approach.

To regenerate the PR jobs for the action:

1. From a terminal, run the following commands (replace `SHA` with the sha of the commit whose checks you want to use, typically this should be the latest from `main`):

```sh
SHA= ####
CHECKS="$(gh api repos/github/codeql-action/commits/${SHA}/check-runs --paginate | jq --compact-output --raw-output '[.["check_runs"] | .[].name | select(contains("https://") or . == "CodeQL" or . == "LGTM.com" or . == "Update dependencies" | not)]')"
CHECKS="$(echo $CHECKS | sed -E 's|\].*\[|,|g')" # Because the gh command is paginated, the results are multiple arrays
echo "{\"contexts\": ${CHECKS}}" > checks.json
gh api -X "PATCH" repos/github/codeql-action/branches/main/protection/required_status_checks --input checks.json
gh api -X "PATCH" repos/github/codeql-action/branches/v1/protection/required_status_checks --input checks.json
````

2. Go to the [branch protection rules settings page](https://github.com/github/codeql-action/settings/branches) and validate that the rules have been updated.


## Resources

- [How to Contribute to Open Source](https://opensource.guide/how-to-contribute/)
Expand Down