Skip to content

Use the checkout_path for getting the commit oid #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aeisenberg merged 4 commits into from
Mar 25, 2022
Merged

Use the checkout_path for getting the commit oid #956

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a92e877
Use the `checkout_path` for getting the commit oid
aeisenberg Feb 28, 2022
5c2600e
Merge branch 'main' into aeisenberg/checkout-path-commitoid
aeisenberg Mar 1, 2022
d068f53
Fix failing tests
aeisenberg Mar 1, 2022
88db5e7
Merge branch 'main' into aeisenberg/checkout-path-commitoid
aeisenberg Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use the checkout_path for getting the commit oid 
This commit also adds a new integration check to verify this.

When running in test mode, payloads will not be uploaded. Instead, they
will be saved to disk so that they can be inspected later.
  • Loading branch information
@aeisenberg
aeisenberg committed Mar 1, 2022
commit a92e8775d8770d4f6f8f6a0a66e956e9235db713
137 changes: 137 additions & 0 deletions .github/workflows/__with-checkout-path.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ No user facing changes.

## 1.1.3 - 23 Feb 2022

- Fix bug where the CLR traces can continue tracing even after tracing should be stopped. [#938](https://github.com/github/codeql-action/pull/938)
- Fix a bug where the CLR traces can continue tracing even after tracing should be stopped. [#938](https://github.com/github/codeql-action/pull/938)
- Fix a bug where an invalid `commit_oid` was being sent to code scanning when a custom checkout path was being used. [#956](https://github.com/github/codeql-action/pull/956)

## 1.1.2 - 17 Feb 2022

Expand Down
13 changes: 9 additions & 4 deletions lib/actions-util.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/actions-util.js.map
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 5 additions & 2 deletions lib/upload-lib.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading