Skip to content

Improve workflow dispatch for Dependabot PRs #4137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mbg wants to merge 3 commits into
base: main
Choose a base branch
from
+532 −116
Draft

Improve workflow dispatch for Dependabot PRs #4137

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
546c457
Refactor Dependabot check expression into constant
mbg Sep 10, 2026
065b8de
Add "Rebuild: Unchanged" label to PRs if rebuild workflow makes no ch…
mbg Sep 10, 2026
f31b0a8
Run workflows when labelled with "Rebuild: Unchanged"
mbg Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Refactor Dependabot check expression into constant
  • Loading branch information
@mbg
mbg committed Sep 10, 2026
commit 546c45705d75cdbe46ad3fe8f9a22e4764a92018
11 changes: 9 additions & 2 deletions pr-checks/sync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,13 @@ function getSetupSteps(checkSpecification: JobSpecification): {
return { inputs: unionAll(inputs), steps };
}

/**
* Condition used to prevent jobs from running for Dependabot PRs
* to avoid unnecessary runs if the "Rebuild" workflow ends up
* changing the JavaScript bundles.
*/
const dependabotCheck = "github.triggering_actor != 'dependabot[bot]'";

/**
* Generates an Actions job from the `checkSpecification`.
*
Expand Down Expand Up @@ -572,7 +579,7 @@ function generateJob(
},
},
name: checkSpecification.name,
if: "github.triggering_actor != 'dependabot[bot]'",
if: dependabotCheck,
permissions: {
contents: "read",
"security-events": "read",
Expand Down Expand Up @@ -622,7 +629,7 @@ function generateValidationJob(

const validationJob: Record<string, any> = {
name: jobSpecification.name,
if: "github.triggering_actor != 'dependabot[bot]'",
if: dependabotCheck,
needs: [checkName],
permissions: {
contents: "read",
Expand Down