Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address review comments
- Stub process.platform/arch in the supported-platform test and loop
  over all supported pairs (including linux/arm64) so it no longer
  depends on the host
- Run the default queries in the Linux Arm64 PR check so the databases
  are finalized end-to-end

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: fb7e2d12-6620-4a67-9c1c-4e82f4a5e8d9
  • Loading branch information
redsun82 and Copilot committed Aug 28, 2026
commit 025009006c2a789de3f2489acec55e71c8153b5f
1 change: 0 additions & 1 deletion .github/workflows/__linux-arm64.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pr-checks/checks/linux-arm64.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ steps:
run: go build main.go
- uses: ./../action/analyze
with:
skip-queries: true
upload-database: false
Comment thread
redsun82 marked this conversation as resolved.
- name: Assert databases exist
run: |
Expand Down
38 changes: 26 additions & 12 deletions src/cli-errors.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -156,20 +156,34 @@ for (const [platform, arch] of [
);
}

test("wrapCliConfigurationError - supported platform", (t) => {
const commandError = new CommandInvocationError(
"codeql",
["version"],
1,
"Some error",
);
const cliError = new CliError(commandError);
for (const [platform, arch] of [
["linux", "x64"],
["linux", "arm64"],
["win32", "x64"],
["darwin", "x64"],
["darwin", "arm64"],
]) {
test.serial(
`wrapCliConfigurationError - ${platform}/${arch} supported`,
(t) => {
sinon.stub(process, "platform").value(platform);
sinon.stub(process, "arch").value(arch);
const commandError = new CommandInvocationError(
"codeql",
["version"],
1,
"Some error",
);
const cliError = new CliError(commandError);

const wrappedError = wrapCliConfigurationError(cliError);
const wrappedError = wrapCliConfigurationError(cliError);

// Should return the original error since platform is supported
t.is(wrappedError, cliError);
});
// Should return the original error since the platform is supported, rather
// than replacing it with the unsupported-platform ConfigurationError.
t.is(wrappedError, cliError);
},
);
}

test("wrapCliConfigurationError - autobuild error", (t) => {
const commandError = new CommandInvocationError(
Expand Down
Loading