Skip to content

Address review comments for #3899 #3904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbg merged 6 commits into from
May 15, 2026
Merged

Address review comments for #3899 #3904

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
db84cb5
Remove outdated comments for `analyze-action` tests
mbg May 15, 2026
9e1f914
Merge `analyze-action-input` test into `analyze-action-env` file
mbg May 15, 2026
4695921
Rename `analyze-action-env.test.ts` to `analyze-action.test.ts`
mbg May 15, 2026
2320f9d
"action" to "Action" in `build.mjs`
mbg May 15, 2026
ab5047b
Add missing semicolons
mbg May 15, 2026
064674d
Fix typo
mbg May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove outdated comments for analyze-action tests
  • Loading branch information
@mbg
mbg committed May 15, 2026
commit db84cb5ccbfdbf6a74bbdc943c5fceb3bd399ebd
7 changes: 0 additions & 7 deletions src/analyze-action-env.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,6 @@ import * as util from "./util";

setupTests(test);

// This test needs to be in its own file so that ava would run it in its own
// nodejs process. The code being tested is in analyze-action.ts, which runs
// immediately on load. So the file needs to be loaded during part of the test,
// and that can happen only once per nodejs process. If multiple such tests are
// in the same test file, ava would run them in the same nodejs process, and all
// but the first test would fail.

test("analyze action with RAM & threads from environment variables", async (t) => {
// This test frequently times out on Windows with the default timeout, so we bump
// it a bit to 20s.
Expand Down
7 changes: 0 additions & 7 deletions src/analyze-action-input.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,6 @@ import * as util from "./util";

setupTests(test);

// This test needs to be in its own file so that ava would run it in its own
// nodejs process. The code being tested is in analyze-action.ts, which runs
// immediately on load. So the file needs to be loaded during part of the test,
// and that can happen only once per nodejs process. If multiple such tests are
// in the same test file, ava would run them in the same nodejs process, and all
// but the first test would fail.

test("analyze action with RAM & threads from action inputs", async (t) => {
t.timeout(1000 * 20);
await util.withTmpDir(async (tmpDir) => {
Expand Down