Skip to content

Reduce duplication across JS bundles by creating one bundle with smaller entry point wrappers #3899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbg merged 11 commits into from
May 15, 2026
+75,202 −1,090,063
Merged

Reduce duplication across JS bundles by creating one bundle with smaller entry point wrappers #3899

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
237b03b
WIP: Reduce bundle duplication
mbg May 14, 2026
f0489ab
Update action specs for new entry points
mbg May 14, 2026
2f137c9
Add remaining new entry points
mbg May 14, 2026
bb30f31
Avoid top-level promise in `analyze-action`
mbg May 14, 2026
d7e50c2
Fix linter errors
mbg May 14, 2026
14085a6
Auto-generate entry points
mbg May 14, 2026
0d08c01
Auto-generate shared bundle
mbg May 14, 2026
52aafec
Import and call `runWrapper` normally in `analyze` tests
mbg May 14, 2026
dfa61e7
Improve pattern matching and error handling
mbg May 14, 2026
7fde13f
Use src + basename in header to avoid issues on Windows
mbg May 14, 2026
127de81
Merge remote-tracking branch 'origin/main' into mbg/esbuild/split
mbg May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Import and call runWrapper normally in analyze tests
  • Loading branch information
@mbg
mbg committed May 14, 2026
commit 52aafec07347933a26e670390c3f894c5c05e64a
10 changes: 2 additions & 8 deletions src/analyze-action-env.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import * as sinon from "sinon";

import * as actionsUtil from "./actions-util";
import * as analyze from "./analyze";
import { runWrapper } from "./analyze-action";
import * as api from "./api-client";
import * as configUtils from "./config-utils";
import * as gitUtils from "./git-utils";
Expand Down Expand Up @@ -62,15 +63,8 @@ test("analyze action with RAM & threads from environment variables", async (t) =

const runFinalizeStub = sinon.stub(analyze, "runFinalize");
const runQueriesStub = sinon.stub(analyze, "runQueries");
// eslint-disable-next-line @typescript-eslint/no-require-imports
const analyzeAction = require("./analyze-action");

// When analyze-action.ts loads, it runs an async function from the top
// level but does not wait for it to finish. To ensure that calls to
// runFinalize and runQueries are correctly captured by spies, we explicitly
// wait for the action promise to complete before starting verification.
// eslint-disable-next-line @typescript-eslint/no-unsafe-call
await analyzeAction.runWrapper();
await runWrapper();

t.assert(
runFinalizeStub.calledOnceWith(
Expand Down
10 changes: 2 additions & 8 deletions src/analyze-action-input.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import * as sinon from "sinon";

import * as actionsUtil from "./actions-util";
import * as analyze from "./analyze";
import { runWrapper } from "./analyze-action";
import * as api from "./api-client";
import * as configUtils from "./config-utils";
import * as gitUtils from "./git-utils";
Expand Down Expand Up @@ -60,15 +61,8 @@ test("analyze action with RAM & threads from action inputs", async (t) => {

const runFinalizeStub = sinon.stub(analyze, "runFinalize");
const runQueriesStub = sinon.stub(analyze, "runQueries");
// eslint-disable-next-line @typescript-eslint/no-require-imports
const analyzeAction = require("./analyze-action");

// When analyze-action.ts loads, it runs an async function from the top
// level but does not wait for it to finish. To ensure that calls to
// runFinalize and runQueries are correctly captured by spies, we explicitly
// wait for the action promise to complete before starting verification.
// eslint-disable-next-line @typescript-eslint/no-unsafe-call
await analyzeAction.runWrapper();
await runWrapper();

t.assert(
runFinalizeStub.calledOnceWith(
Expand Down