Combine basic jobs to reduce Actions usage

henrymercer · Aug 29, 2025 · Aug 21, 2025 · Aug 21, 2025 · Aug 21, 2025 · Aug 21, 2025
commit 3edad3eebd6f0cc8ec9eeae4051e359fe42f9639
@@ -9,74 +9,52 @@ on:
   workflow_dispatch:
 
 jobs:
-  check-js:
-    name: Check JS
-    runs-on: ubuntu-latest
-    timeout-minutes: 45
+  unit-tests:
+    name: Unit Tests
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, macos-latest, windows-latest]
     permissions:
       contents: read
       security-events: write # needed to upload ESLint results
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v5
-
-      - name: Install dependencies
-        run: npm install
-
-      - name: Lint
-        id: lint
-        run: npm run lint-ci
-
-      - name: Upload sarif
-        uses: github/codeql-action/upload-sarif@v3
-        with:
-          sarif_file: eslint.sarif
-          category: eslint
-
-      - name: Check generated JS
-        run: .github/workflows/script/check-js.sh
-
-  check-file-contents:
-    name: Check file contents
-    permissions:
-      contents: read
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
     timeout-minutes: 45
 
     steps:
-      - name: Checkout
-        uses: actions/checkout@v5
+      - uses: actions/checkout@v5
+
+      - name: Install dependencies
+        run: |
+          # Use the system Bash shell to ensure we can run commands like `npm install`
+          # that are not available in the default shell on Windows.
+          npm config set script-shell bash
+          npm install
 
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
           python-version: 3.11
 
-      # Ensure the generated PR check workflows are up to date.
+      - name: Verify compiled JS up to date
+        run: .github/workflows/script/check-js.sh
+
       - name: Verify PR checks up to date
         run: .github/workflows/script/verify-pr-checks.sh
 
-  npm-test:
-    name: Unit Test
-    strategy:
-      fail-fast: false
-      matrix:
-        os: [ubuntu-latest, macos-latest, windows-latest]
-    permissions:
-      contents: read
-    runs-on: ${{ matrix.os }}
-    timeout-minutes: 45
+      - name: Run unit tests
+        run: npm test
 
-    steps:
-      - uses: actions/checkout@v5
-      - name: npm test
-        run: |
-          # Run any commands referenced in package.json using Bash, otherwise
-          # we won't be able to find them on Windows.
-          npm config set script-shell bash
-          npm install
-          npm test
+      - name: Lint
+        id: lint
+        run: npm run lint-ci
+
+      - name: Upload sarif
+        uses: github/codeql-action/upload-sarif@v3
+        if: matrix.os == 'ubuntu-latest'
+        with:
+          sarif_file: eslint.sarif
+          category: eslint
 
   check-node-version:
     if: github.event.pull_request