Repository navigation
Respect proxy settings when streaming the download and extraction of the CodeQL bundle #2624
ci: add configuration tto run proxy with zstd package to test streami…
…ng with proxy
- Loading branch information
commit 78be2f13336dc457973edb5e350e589e622028dc
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Perform all necessary steps to update the PR checks | ||
| update-pr-checks: | ||
|
NlightNFotis marked this conversation as resolved.
|
||
| python3 -m venv env | ||
| env/bin/activate | ||
| pip3 install ruamel.yaml | ||
| python3 sync.py | ||
| git apply pr-checks.patch | ||
|
NlightNFotis marked this conversation as resolved.
Outdated
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| diff --git a/.github/workflows/__test-proxy.yml b/.github/workflows/__test-proxy.yml | ||
| index b6831b7a0..3be758b02 100644 | ||
| --- a/.github/workflows/__test-proxy.yml | ||
| +++ b/.github/workflows/__test-proxy.yml | ||
| @@ -45,6 +45,13 @@ jobs: | ||
| python-version: '3.11' | ||
| - name: Check out repository | ||
| uses: actions/checkout@v4 | ||
| + - name: Set up GitHub CLI | ||
| + run: | | ||
| + curl -fsSL https://cli.github.com/packages/githubcli-archive-keyring.gpg | sudo dd of=/usr/share/keyrings/githubcli-archive-keyring.gpg | ||
| + sudo apt-key add /usr/share/keyrings/githubcli-archive-keyring.gpg | ||
| + sudo apt-add-repository https://cli.github.com/packages | ||
| + sudo apt-get update | ||
| + sudo apt-get install gh | ||
| - name: Prepare test | ||
| id: prepare-test | ||
| uses: ./.github/actions/prepare-test |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test was passing before when we were streaming zstd bundles with a CodeQL Action version that wasn't respecting proxy settings, presumably because the CodeQL Action could still access the bundle without the proxy.
Can we update the test to ensure that we're downloading the bundle via the proxy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the latest test added as part of this PR, I'm fairly confident we're downloading the bundle through the proxy.
The reason it worked before is that it didn't test the streaming of the bundle, because when
linkedis passed as theversion, theprepare-stepaction was choosing the.tar.gzbundle by default - as example the latest run from a PR merged recently.I am not sure though how it makes that selection between the
.tar.gzand the.tar.zstone, because in this PR, the same job downloaded the.tar.zstone. But previously, we didn't go through this code because the same job was opting for the.tar.gzwhen downloading.Will look more into that and report back any interesting findings.