Skip to content

SSA: Tolerate multiple variables being read at the same CFG node #22744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asgerf wants to merge 13 commits into
base: main
Choose a base branch
from
Open

SSA: Tolerate multiple variables being read at the same CFG node #22744

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3137897
unified: Add test showing spurious SSA flow
asgerf Oct 2, 2026
f906f8d
Ssa: Add consistency check for ambiguous read
asgerf Oct 2, 2026
9d8f5e6
unified: Add consistency check
asgerf Oct 2, 2026
b1b2b20
ssa: Expose new consistency check from VariableCapture.qll
asgerf Oct 2, 2026
b2f9e09
ssa: Record ambiguousReadNode errors from VariableCapture
asgerf Oct 2, 2026
8957cda
ssa: Associate ExprNode with a variable
asgerf Oct 2, 2026
c084707
ssa: Record absense of ambiguousReadNode errors
asgerf Oct 2, 2026
649e8cc
unified: Update local SSA consistency output
asgerf Oct 2, 2026
0164aff
unified: Update unit test output
asgerf Oct 2, 2026
ee7fc86
unified: Update path-injection output
asgerf Oct 2, 2026
2c637ab
unified: Mostly restore path-injection results
asgerf Oct 2, 2026
cbd6d35
ssa: Fix bad join order
asgerf Oct 5, 2026
32e5525
ssa: Update some uses of ExprNode to bind the variable
asgerf Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ssa: Expose new consistency check from VariableCapture.qll
  • Loading branch information
@asgerf
asgerf committed Oct 2, 2026
commit b1b2b2008c61872085b2bf1a7e760e557cb94adc
1 change: 1 addition & 0 deletions csharp/ql/consistency-queries/SsaConsistency.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import csharp
import semmle.code.csharp.dataflow.internal.SsaImpl as Impl
import Impl::Consistency
import Impl::DataFlowIntegration::DfConsistency
import Ssa

query predicate localDeclWithSsaDef(LocalVariableDeclExpr d) {
Expand Down
1 change: 1 addition & 0 deletions java/ql/consistency-queries/SsaConsistency.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import java
import semmle.code.java.dataflow.internal.SsaImpl
import Impl::Consistency
import DataFlowIntegration::DfConsistency
1 change: 1 addition & 0 deletions ruby/ql/consistency-queries/SsaConsistency.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import codeql.ruby.dataflow.SSA
import codeql.ruby.dataflow.internal.SsaImpl
import Consistency
import DataFlowIntegration::DfConsistency
1 change: 1 addition & 0 deletions rust/ql/consistency-queries/SsaConsistency.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@
import codeql.rust.dataflow.Ssa
import codeql.rust.dataflow.internal.SsaImpl
import Consistency
import DataFlowIntegration::DfConsistency
2 changes: 2 additions & 0 deletions shared/dataflow/codeql/dataflow/VariableCapture.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,8 @@ module Flow<
msg = "Callable has multiple locations" and 2 <= strictcount(c.getLocation())
}

import SsaFlow::DfConsistency

query predicate consistencyOverview(string msg, int n) {
uniqueToString(msg, n) or
n = strictcount(BasicBlock bb | uniqueEnclosingCallable(bb, msg)) or
Expand Down