Conversation
I think it's unlikely that this will be used in an exploit, but we treat `for char in string: ...` as preserving taint, so we might as well do the same for this iterator.
tausbn
force-pushed
the
tausbn/python315-model-unicodedata-iter-graphemes
branch
from
October 2, 2026 13:29
14b5f6a to
94caab3
Compare
tausbn
marked this pull request as ready for review
October 2, 2026 13:38
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The narrow model follows existing taint semantics and has focused regression coverage, with no unresolved findings.
Review effort: Balanced
Findings: None
What changed in this PR
Adds taint-flow modeling for Python 3.15’s unicodedata.iter_graphemes, consistent with existing string-iteration behavior.
Changes:
- Propagates input-string taint to the returned iterator.
- Adds regression cases for iteration, aliases, callbacks, bounds, and clean inputs.
- Documents the analysis improvement.
| File | Description |
|---|---|
| python/ql/test/library-tests/frameworks/stdlib/test_unicodedata.py | Tests taint propagation and negative cases. |
| python/ql/lib/semmle/python/frameworks/Stdlib.model.yml | Adds the iter_graphemes taint summary. |
| python/ql/lib/change-notes/2026-09-30-python315-graphemes.md | Records the new modeling support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's unlikely that this will be used in an exploit, but we treat
for char in string: ...as preserving taint, so we might as well do the same for this iterator.