Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The regression fix lacks targeted test coverage for explicit or synthesized constructors.
Review effort: Balanced
Findings: 1
What changed in this PR
Ensures Swift constructor identifiers are treated as declarations rather than statically resolvable references.
Changes:
- Adds constructors to local name-binding contexts.
| File | Description |
|---|---|
unified/ql/lib/codeql/unified/internal/LocalNameBinding.qll |
Classifies constructor name nodes as bindings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+289
to
+293
| exists(ConstructorDeclaration decl | | ||
| getChild(scope, _) = decl and | ||
| pattern = decl.getNameNode() and | ||
| declaration = decl | ||
| ) |
asgerf
approved these changes
Oct 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On #22721 we saw a regression in statically resolvable names, which happens because we mistakenly consider constructor identifiers (
init) to be resolvable, and since that PR added more constructors, it would appear we could resolve fewer names.The fix is to handle constructors similar to other members with an identifier.
DCA confirms.