Skip to content

Cpp: new experimental query cpp/guarded-free #16331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MathiasVP merged 4 commits into from
May 1, 2024
Merged

Cpp: new experimental query cpp/guarded-free #16331

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d7c784e
Initial commit of experimental query cpp/guarded-free.
mario-campos Apr 25, 2024
3195f0c
Use more specific `hasGlobalName()` for stdlib function free(3)
mario-campos Apr 26, 2024
c480431
C++: simplify cpp/guarded-free
mario-campos May 1, 2024
5a7a1dc
C++: forgot to import semmle.code.cpp.controlflow.Guards
mario-campos May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use more specific hasGlobalName() for stdlib function free(3) 
Based on the CodeQL documentation's example of strncpy(3) and strlen(3): https://codeql.github.com/docs/codeql-language-guides/hash-consing-and-value-numbering/#example-query
  • Loading branch information
@mario-campos
mario-campos committed Apr 26, 2024
commit 3195f0c8288fd00af329ad25a0043e069a376c40
2 changes: 1 addition & 1 deletion cpp/ql/src/experimental/Best Practices/GuardedFree.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import cpp

class FreeCall extends FunctionCall {
FreeCall() { this.getTarget().hasName("free") }
FreeCall() { this.getTarget().hasGlobalName("free") }
}

from IfStmt stmt, FreeCall fc, Variable v
Expand Down